Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253103006: Rename IsSimdObject assembly intrinsic. (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename IsSimdObject assembly intrinsic. Change IS_SIMD_OBJECT to IS_SIMD_VALUE, and IsSimdObject to IsSimdValue. R=rossberg LOG=N BUG=v8:4124 Committed: https://crrev.com/34bd773eb6e28b3c3ee2cccac3f16d1f7b86df55 Cr-Commit-Position: refs/heads/master@{#30004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.js View 9 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-simd.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bbudge
5 years, 4 months ago (2015-08-04 14:12:37 UTC) #1
rossberg
LGTM, thanks!
5 years, 4 months ago (2015-08-04 14:15:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253103006/1
5 years, 4 months ago (2015-08-04 14:33:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 14:36:57 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 14:37:18 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/34bd773eb6e28b3c3ee2cccac3f16d1f7b86df55
Cr-Commit-Position: refs/heads/master@{#30004}

Powered by Google App Engine
This is Rietveld 408576698