[android_webview] Make intercepted URLRequests have status codes.

android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/input_stream.h"
 #include "android_webview/browser/net/android_stream_reader_url_request_job.h"
 #include "android_webview/browser/net/aw_url_request_job_factory.h"
 #include "android_webview/browser/net/input_stream_reader.h"
 #include "base/format_macros.h"
 #include "base/message_loop.h"
@@ skipping 77 matching lines @@
 
   virtual bool GetCharset(
       JNIEnv* env,
       net::URLRequest* request,
       android_webview::InputStream* stream,
       std::string* charset) {
     return false;
   }
 };
 
+class NullStreamReaderDelegate : public StreamReaderDelegate {
+ public:
+  NullStreamReaderDelegate() {}
+
+  virtual scoped_ptr<InputStream> OpenInputStream(
+      JNIEnv* env,
+      const GURL& url) {
+    return make_scoped_ptr<InputStream>(NULL);
+  }
+};
+
 class MockInputStreamReader : public InputStreamReader {
  public:
   MockInputStreamReader() : InputStreamReader(new NotImplInputStream()) {}
   ~MockInputStreamReader() {}
 
   MOCK_METHOD1(Seek, int(const net::HttpByteRange& byte_range));
   MOCK_METHOD2(ReadRawData, int(net::IOBuffer* buffer, int buffer_size));
 };
 
 
@@ skipping 45 matching lines @@
   void SetRange(net::URLRequest* req, int first_byte, int last_byte) {
     net::HttpRequestHeaders headers;
     headers.SetHeader(net::HttpRequestHeaders::kRange,
                       base::StringPrintf(
                            "bytes=%" PRIuS "-%" PRIuS,
                            first_byte, last_byte));
     req->SetExtraRequestHeaders(headers);
   }
 
   void SetUpTestJob(scoped_ptr<InputStreamReader> stream_reader) {
-    scoped_ptr<AndroidStreamReaderURLRequestJob::Delegate>
-        stream_reader_delegate(new StreamReaderDelegate());
+    SetUpTestJob(stream_reader.Pass(),
+                 make_scoped_ptr(new StreamReaderDelegate())
+                     .PassAs<AndroidStreamReaderURLRequestJob::Delegate>());
+  }
+
+  void SetUpTestJob(scoped_ptr<InputStreamReader> stream_reader,
+                    scoped_ptr<AndroidStreamReaderURLRequestJob::Delegate>
+                        stream_reader_delegate) {
     TestStreamReaderJob* test_stream_reader_job =
         new TestStreamReaderJob(
             req_.get(),
             &network_delegate_,
             stream_reader_delegate.Pass(),
             stream_reader.Pass());
     // The Interceptor is owned by the |factory_|.
     TestJobInterceptor* protocol_handler = new TestJobInterceptor;
     protocol_handler->set_main_intercept_job(test_stream_reader_job);
     bool set_protocol = factory_.SetProtocolHandler("http", protocol_handler);
@@ skipping 26 matching lines @@
 
   SetUpTestJob(stream_reader.PassAs<InputStreamReader>());
 
   req_->Start();
 
   // The TestDelegate will quit the message loop on request completion.
   MessageLoop::current()->Run();
 
   EXPECT_FALSE(url_request_delegate_.request_failed());
   EXPECT_EQ(1, network_delegate_.completed_requests());
+  EXPECT_EQ(0, network_delegate_.error_count());
+  EXPECT_EQ(200, req_->GetResponseCode());
+}
+
+TEST_F(AndroidStreamReaderURLRequestJobTest, ReadWithNullStream) {
+  SetUpTestJob(scoped_ptr<InputStreamReader>(),
+               make_scoped_ptr(new NullStreamReaderDelegate())
+                   .PassAs<AndroidStreamReaderURLRequestJob::Delegate>());
+  req_->Start();
+
+  // The TestDelegate will quit the message loop on request completion.
+  MessageLoop::current()->Run();
+
+  // The request_failed() method is named confusingly but all it checks is
+  // whether the request got as far as calling NotifyHeadersComplete.
+  EXPECT_FALSE(url_request_delegate_.request_failed());
+  EXPECT_EQ(1, network_delegate_.completed_requests());
+  // A null input stream shouldn't result in an error. See crbug.com/180950.
+  EXPECT_EQ(0, network_delegate_.error_count());
+  EXPECT_EQ(404, req_->GetResponseCode());
 }
 
 TEST_F(AndroidStreamReaderURLRequestJobTest, ReadPartOfStream) {
   const int bytes_available = 128;
   const int offset = 32;
   const int bytes_to_read = bytes_available - offset;
   scoped_ptr<StrictMock<MockInputStreamReader> > stream_reader(
       new StrictMock<MockInputStreamReader>());
   {
     InSequence s;
@@ skipping 10 matching lines @@
   SetUpTestJob(stream_reader.PassAs<InputStreamReader>());
 
   SetRange(req_.get(), offset, bytes_available);
   req_->Start();
 
   MessageLoop::current()->Run();
 
   EXPECT_FALSE(url_request_delegate_.request_failed());
   EXPECT_EQ(bytes_to_read, url_request_delegate_.bytes_received());
   EXPECT_EQ(1, network_delegate_.completed_requests());
+  EXPECT_EQ(0, network_delegate_.error_count());
 }
 
 TEST_F(AndroidStreamReaderURLRequestJobTest,
        ReadStreamWithMoreAvailableThanActual) {
   const int bytes_available_reported = 190;
   const int bytes_available = 128;
   const int offset = 0;
   const int bytes_to_read = bytes_available - offset;
   scoped_ptr<StrictMock<MockInputStreamReader> > stream_reader(
       new StrictMock<MockInputStreamReader>());
@@ skipping 10 matching lines @@
   SetUpTestJob(stream_reader.PassAs<InputStreamReader>());
 
   SetRange(req_.get(), offset, bytes_available_reported);
   req_->Start();
 
   MessageLoop::current()->Run();
 
   EXPECT_FALSE(url_request_delegate_.request_failed());
   EXPECT_EQ(bytes_to_read, url_request_delegate_.bytes_received());
   EXPECT_EQ(1, network_delegate_.completed_requests());
+  EXPECT_EQ(0, network_delegate_.error_count());
 }
 
 TEST_F(AndroidStreamReaderURLRequestJobTest, DeleteJobMidWaySeek) {
   const int offset = 20;
   const int bytes_available = 128;
   base::RunLoop loop;
   scoped_ptr<StrictMock<MockInputStreamReader> > stream_reader(
       new StrictMock<MockInputStreamReader>());
   EXPECT_CALL(*stream_reader, Seek(_))
       .WillOnce(DoAll(InvokeWithoutArgs(&loop, &base::RunLoop::Quit),
@@ skipping 30 matching lines @@
 
   SetRange(req_.get(), offset, bytes_available);
   req_->Start();
 
   loop.Run();
 
   EXPECT_EQ(0, network_delegate_.completed_requests());
   req_->Cancel();
   EXPECT_EQ(1, network_delegate_.completed_requests());
 }