Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: Tools/Scripts/webkitpy/common/system/executive_unittest.py

Issue 1253013003: Remove all perl scripts from Tools/Scripts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove the python code to invoke Perl \o/ Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/common/system/executive.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/common/system/executive_unittest.py
diff --git a/Tools/Scripts/webkitpy/common/system/executive_unittest.py b/Tools/Scripts/webkitpy/common/system/executive_unittest.py
index 0f3d9170443683013aee6ee608178144cec960c0..57f39b9320464a2336ab3861938d824c14e5850d 100644
--- a/Tools/Scripts/webkitpy/common/system/executive_unittest.py
+++ b/Tools/Scripts/webkitpy/common/system/executive_unittest.py
@@ -88,11 +88,7 @@ class ExecutiveTest(unittest.TestCase):
def test_interpreter_for_script(self):
self.assert_interpreter_for_content(None, '')
self.assert_interpreter_for_content(None, 'abcd\nefgh\nijklm')
- self.assert_interpreter_for_content(None, '##/usr/bin/perl')
- self.assert_interpreter_for_content('perl', '#!/usr/bin/env perl')
- self.assert_interpreter_for_content('perl', '#!/usr/bin/env perl\nfirst\nsecond')
- self.assert_interpreter_for_content('perl', '#!/usr/bin/perl')
- self.assert_interpreter_for_content('perl', '#!/usr/bin/perl -w')
+ self.assert_interpreter_for_content(None, '##/usr/bin/env python')
Julien - ping for review 2015/07/31 21:51:25 Dirk, I think this unit test updates makes sense.
Dirk Pranke 2015/07/31 22:01:24 Yup, that's fine. Still lgtm.
self.assert_interpreter_for_content(sys.executable, '#!/usr/bin/env python')
self.assert_interpreter_for_content(sys.executable, '#!/usr/bin/env python\nfirst\nsecond')
self.assert_interpreter_for_content(sys.executable, '#!/usr/bin/python')
« no previous file with comments | « Tools/Scripts/webkitpy/common/system/executive.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698