Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1253013003: Remove all perl scripts from Tools/Scripts (Closed)

Created:
5 years, 4 months ago by Julien - ping for review
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, joelo
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove all perl scripts from Tools/Scripts Some perl unit tests were failing as we removed some needed dependencies. As no one noticed in above a year, it should be safe to remove all of them. This change removes anything referencing perl in Tools/Scripts. It updates some python unit tests now that Perl cannot be run from the python code. BUG=347866 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199914

Patch Set 1 #

Patch Set 2 : Remove the python code to invoke Perl \o/ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17409 lines) Patch
D Tools/Scripts/VCSUtils.pm View 1 chunk +0 lines, -2155 lines 0 comments Download
D Tools/Scripts/add-include View 1 chunk +0 lines, -135 lines 0 comments Download
D Tools/Scripts/bencher View 1 chunk +0 lines, -2101 lines 0 comments Download
D Tools/Scripts/check-dom-results View 1 chunk +0 lines, -141 lines 0 comments Download
D Tools/Scripts/check-for-exit-time-destructors View 1 chunk +0 lines, -152 lines 0 comments Download
D Tools/Scripts/check-for-global-initializers View 1 chunk +0 lines, -167 lines 0 comments Download
D Tools/Scripts/check-for-weak-vtables-and-externals View 1 chunk +0 lines, -120 lines 0 comments Download
D Tools/Scripts/clean-header-guards View 1 chunk +0 lines, -53 lines 0 comments Download
D Tools/Scripts/commit-log-editor View 1 chunk +0 lines, -371 lines 0 comments Download
D Tools/Scripts/compare-timing-files View 1 chunk +0 lines, -88 lines 0 comments Download
D Tools/Scripts/debug-test-runner View 1 chunk +0 lines, -37 lines 0 comments Download
D Tools/Scripts/do-file-rename View 1 chunk +0 lines, -116 lines 0 comments Download
D Tools/Scripts/do-webcore-rename View 1 chunk +0 lines, -251 lines 0 comments Download
D Tools/Scripts/find-extra-includes View 1 chunk +0 lines, -102 lines 0 comments Download
D Tools/Scripts/parse-malloc-history View 1 chunk +0 lines, -177 lines 0 comments Download
D Tools/Scripts/report-include-statistics View 1 chunk +0 lines, -114 lines 0 comments Download
D Tools/Scripts/sampstat View 1 chunk +0 lines, -98 lines 0 comments Download
D Tools/Scripts/show-pretty-diff View 1 chunk +0 lines, -79 lines 0 comments Download
D Tools/Scripts/split-file-by-class View 1 chunk +0 lines, -159 lines 0 comments Download
D Tools/Scripts/svn-apply View 1 chunk +0 lines, -475 lines 0 comments Download
D Tools/Scripts/svn-create-patch View 1 chunk +0 lines, -437 lines 0 comments Download
D Tools/Scripts/svn-unapply View 1 chunk +0 lines, -283 lines 0 comments Download
D Tools/Scripts/test-webkit-scripts View 1 chunk +0 lines, -86 lines 0 comments Download
D Tools/Scripts/test-webkitperl View 1 chunk +0 lines, -59 lines 0 comments Download
D Tools/Scripts/test-webkitruby View 1 chunk +0 lines, -34 lines 0 comments Download
D Tools/Scripts/webkitdirs.pm View 1 chunk +0 lines, -2863 lines 0 comments Download
D Tools/Scripts/webkitperl/LoadAsModule.pm View 1 chunk +0 lines, -80 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl View 1 chunk +0 lines, -525 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl View 1 chunk +0 lines, -92 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl View 1 chunk +0 lines, -87 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl View 1 chunk +0 lines, -336 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl View 1 chunk +0 lines, -267 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl View 1 chunk +0 lines, -1277 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl View 1 chunk +0 lines, -121 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl View 1 chunk +0 lines, -486 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl View 1 chunk +0 lines, -63 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl View 1 chunk +0 lines, -494 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl View 1 chunk +0 lines, -94 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl View 1 chunk +0 lines, -443 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl View 1 chunk +0 lines, -288 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl View 1 chunk +0 lines, -805 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl View 1 chunk +0 lines, -257 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl View 1 chunk +0 lines, -136 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl View 1 chunk +0 lines, -56 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl View 1 chunk +0 lines, -75 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl View 1 chunk +0 lines, -92 lines 0 comments Download
D Tools/Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl View 1 chunk +0 lines, -128 lines 0 comments Download
D Tools/Scripts/webkitperl/httpd.pm View 1 chunk +0 lines, -347 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_unittest.py View 1 1 chunk +1 line, -5 lines 2 comments Download

Messages

Total messages: 27 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253013003/1
5 years, 4 months ago (2015-07-31 15:54:44 UTC) #4
Julien - ping for review
Perl removal \o/ I think I got all of them but would appreciate a second ...
5 years, 4 months ago (2015-07-31 16:42:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 17:07:38 UTC) #8
Julien - ping for review
-dirknke@ +the right Dirk :)
5 years, 4 months ago (2015-07-31 18:05:13 UTC) #10
Dirk Pranke
lgtm. +joelo fyi what does "It keeps the ability to run perl scripts in webkitpy ...
5 years, 4 months ago (2015-07-31 18:14:00 UTC) #11
Julien - ping for review
On 2015/07/31 at 18:14:00, dpranke wrote: > lgtm. > > +joelo fyi > > what ...
5 years, 4 months ago (2015-07-31 18:25:55 UTC) #12
Dirk Pranke
On 2015/07/31 18:25:55, Julien Chaffraix - PST wrote: > On 2015/07/31 at 18:14:00, dpranke wrote: ...
5 years, 4 months ago (2015-07-31 18:29:36 UTC) #13
Julien - ping for review
On 2015/07/31 at 18:29:36, dpranke wrote: > On 2015/07/31 18:25:55, Julien Chaffraix - PST wrote: ...
5 years, 4 months ago (2015-07-31 20:24:55 UTC) #14
Julien - ping for review
https://codereview.chromium.org/1253013003/diff/20001/Tools/Scripts/webkitpy/common/system/executive_unittest.py File Tools/Scripts/webkitpy/common/system/executive_unittest.py (right): https://codereview.chromium.org/1253013003/diff/20001/Tools/Scripts/webkitpy/common/system/executive_unittest.py#newcode91 Tools/Scripts/webkitpy/common/system/executive_unittest.py:91: self.assert_interpreter_for_content(None, '##/usr/bin/env python') Dirk, I think this unit test ...
5 years, 4 months ago (2015-07-31 21:51:25 UTC) #15
Dirk Pranke
https://codereview.chromium.org/1253013003/diff/20001/Tools/Scripts/webkitpy/common/system/executive_unittest.py File Tools/Scripts/webkitpy/common/system/executive_unittest.py (right): https://codereview.chromium.org/1253013003/diff/20001/Tools/Scripts/webkitpy/common/system/executive_unittest.py#newcode91 Tools/Scripts/webkitpy/common/system/executive_unittest.py:91: self.assert_interpreter_for_content(None, '##/usr/bin/env python') On 2015/07/31 21:51:25, Julien Chaffraix - ...
5 years, 4 months ago (2015-07-31 22:01:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253013003/20001
5 years, 4 months ago (2015-07-31 23:09:40 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/72260)
5 years, 4 months ago (2015-08-01 00:30:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253013003/20001
5 years, 4 months ago (2015-08-03 16:39:08 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/64822)
5 years, 4 months ago (2015-08-03 18:00:31 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253013003/20001
5 years, 4 months ago (2015-08-03 20:05:28 UTC) #26
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 20:55:12 UTC) #27
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199914

Powered by Google App Engine
This is Rietveld 408576698