Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1253003005: bump the size of the atlas id to 64 bits (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/chrome/m45
Project:
skia
Visibility:
Public.

Description

bump the size of the atlas id to 64 bits BUG=skia: Committed: https://skia.googlesource.com/skia/+/8db6fdc465e0f76b1f8eb0d5f799d42b7c2246f5

Patch Set 1 #

Patch Set 2 : more correct #

Patch Set 3 : tweaks #

Total comments: 6

Patch Set 4 : tweaks #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M src/gpu/GrBatchAtlas.h View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 2 3 4 10 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
joshualitt
ptal
5 years, 4 months ago (2015-07-31 14:04:23 UTC) #2
bsalomon
On 2015/07/31 14:04:23, joshualitt wrote: > ptal lgtm
5 years, 4 months ago (2015-07-31 14:25:28 UTC) #3
joshualitt
On 2015/07/31 14:25:28, bsalomon wrote: > On 2015/07/31 14:04:23, joshualitt wrote: > > ptal > ...
5 years, 4 months ago (2015-07-31 14:33:28 UTC) #4
robertphillips
https://codereview.chromium.org/1253003005/diff/40001/src/gpu/GrBatchAtlas.cpp File src/gpu/GrBatchAtlas.cpp (right): https://codereview.chromium.org/1253003005/diff/40001/src/gpu/GrBatchAtlas.cpp#newcode21 src/gpu/GrBatchAtlas.cpp:21: SkASSERT(index < (1 << 16)); SkASSERT(generation < (1 << ...
5 years, 4 months ago (2015-07-31 15:00:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253003005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253003005/60001
5 years, 4 months ago (2015-07-31 15:05:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2389) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-07-31 15:07:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253003005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253003005/80001
5 years, 4 months ago (2015-07-31 15:17:39 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:25:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/8db6fdc465e0f76b1f8eb0d5f799d42b7c2246f5

Powered by Google App Engine
This is Rietveld 408576698