Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: trunk/tests/PointTest.cpp

Issue 12530010: add asScalars() to document when we want to treat SkPoint or SkRect as an array (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/include/core/SkRect.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/tests/PointTest.cpp
===================================================================
--- trunk/tests/PointTest.cpp (revision 8035)
+++ trunk/tests/PointTest.cpp (working copy)
@@ -8,8 +8,20 @@
// Unit tests for src/core/SkPoint.cpp and its header
#include "SkPoint.h"
+#include "SkRect.h"
#include "Test.h"
+static void test_casts(skiatest::Reporter* reporter) {
+ SkPoint p = { 0, 0 };
+ SkRect r = { 0, 0, 0, 0 };
+
+ const SkScalar* pPtr = SkTCast<const SkScalar*>(&p);
+ const SkScalar* rPtr = SkTCast<const SkScalar*>(&r);
+
+ REPORTER_ASSERT(reporter, p.asScalars() == pPtr);
+ REPORTER_ASSERT(reporter, r.asScalars() == rPtr);
+}
+
// Tests that SkPoint::length() and SkPoint::Length() both return
// approximately expectedLength for this (x,y).
static void test_length(skiatest::Reporter* reporter, SkScalar x, SkScalar y,
@@ -37,6 +49,8 @@
}
static void PointTest(skiatest::Reporter* reporter) {
+ test_casts(reporter);
+
test_length(reporter, SkIntToScalar(3), SkIntToScalar(4), SkIntToScalar(5));
test_length(reporter, SkFloatToScalar(0.6f), SkFloatToScalar(0.8f),
SK_Scalar1);
« no previous file with comments | « trunk/include/core/SkRect.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698