Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1252993004: Pass the kGCCallbackFlagForced from AdjustAmountOfExternalAllocatedMemory. (Closed)

Created:
5 years, 4 months ago by epertoso
Modified:
5 years, 4 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass the kGCCallbackFlagForced flag when invoking Heap::CollectAllGarbage from AdjustAmountOfExternalAllocatedMemory. This forces the second pass of the pending phantom callbacks to run immediately after the first. BUG=chromium:511294 LOG=Y Committed: https://crrev.com/aec8987b5ee55fa46b90b58927e957a4e5f19c09 Cr-Commit-Position: refs/heads/master@{#29933}

Patch Set 1 #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
epertoso
5 years, 4 months ago (2015-07-28 11:05:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252993004/20001
5 years, 4 months ago (2015-07-28 11:05:22 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-28 13:07:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 08:16:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252993004/20001
5 years, 4 months ago (2015-07-30 13:16:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 13:41:49 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 13:42:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aec8987b5ee55fa46b90b58927e957a4e5f19c09
Cr-Commit-Position: refs/heads/master@{#29933}

Powered by Google App Engine
This is Rietveld 408576698