Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart_utils.js

Issue 1252953003: Implement more of dart:mirrors (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_js_mirrors.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | lib/src/codegen/js_codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_utils.js
diff --git a/lib/runtime/dart_utils.js b/lib/runtime/dart_utils.js
index 70555c729187a9577eebf25ccaff6bb7a202332b..a1c2bf9762b48b8a6ebae02a67a503018c3b7306 100644
--- a/lib/runtime/dart_utils.js
+++ b/lib/runtime/dart_utils.js
@@ -113,7 +113,7 @@ var dart_utils =
show = getOwnNamesAndSymbols(from);
}
if (hide != void 0) {
- var hideMap = new Map(hide);
+ var hideMap = new Set(hide);
vsm 2015/08/07 18:20:33 John - does this look right? I was hitting an err
Jennifer Messerly 2015/08/07 18:52:59 oh my gosh, good catch, it was supposed to be Set.
show = show.filter((k) => !hideMap.has(k));
}
return copyTheseProperties(to, from, show);
« no previous file with comments | « lib/runtime/dart/_js_mirrors.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | lib/src/codegen/js_codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698