Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: tool/sdk_expected_errors.txt

Issue 1252953003: Implement more of dart:mirrors (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index 337800890ccb1419fec5ba4a82b0a46fd9f62082..d1eb48cb593fe1855fa94a58811519483701b75f 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -375,10 +375,7 @@ warning: [DownCastImplicit] list (Object) will need runtime check to cast to typ
warning: [DownCastComposite] callMethod('splice', [index, 1])[0] (dynamic) will need runtime check to cast to type E (dart:js, line 404, col 12)
warning: [DownCastComposite] callMethod('pop') (dynamic) will need runtime check to cast to type E (dart:js, line 409, col 12)
warning: [DownCastImplicit] ms (num) will need runtime check to cast to type int (dart:js, line 486, col 52)
-severe: [AnalyzerMessage] Missing concrete implementation of getter 'TypeMirror.typeArguments', getter 'TypeMirror.isOriginalDeclaration', getter 'DeclarationMirror.owner', getter 'DeclarationMirror.location' and 10 more (dart:_js_mirrors, line 120, col 7)
-severe: [AnalyzerMessage] Missing concrete implementation of getter 'InstanceMirror.type', getter 'InstanceMirror.hasReflectee' and 'InstanceMirror.delegate' (dart:_js_mirrors, line 47, col 7)
-severe: [AnalyzerMessage] Missing concrete implementation of getter 'VariableMirror.isStatic', getter 'VariableMirror.isFinal', getter 'DeclarationMirror.owner', getter 'ParameterMirror.isOptional' and 9 more (dart:_js_mirrors, line 126, col 7)
-severe: [AnalyzerMessage] Missing concrete implementation of getter 'TypeMirror.typeArguments', getter 'ClassMirror.superinterfaces', getter 'TypeMirror.isOriginalDeclaration', getter 'ClassMirror.staticMembers' and 19 more (dart:_js_mirrors, line 84, col 7)
-severe: [AnalyzerMessage] Missing concrete implementation of getter 'MethodMirror.isSetter', getter 'MethodMirror.isConstructor', getter 'MethodMirror.isConstConstructor', getter 'MethodMirror.isAbstract' and 17 more (dart:_js_mirrors, line 134, col 7)
-severe: [AnalyzerMessage] The argument type 'void' cannot be assigned to the parameter type 'Object' (dart:_js_mirrors, line 61, col 35)
+severe: [AnalyzerMessage] 'fn' is not a method (dart:_js_mirrors, line 105, col 41)
Jennifer Messerly 2015/07/24 16:28:28 fix these?
vsm 2015/08/07 17:07:33 Done.
+severe: [AnalyzerMessage] The argument type 'void' cannot be assigned to the parameter type 'Object' (dart:_js_mirrors, line 64, col 35)
+severe: [InvalidMethodOverride] Invalid override. The type of JsClassMirror.superclass (() → TypeMirror) is not a subtype of ClassMirror.superclass (() → ClassMirror). (dart:_js_mirrors, line 151, col 3)
warning: [DownCastImplicit] (tm as ClassMirror).originalDeclaration (TypeMirror) will need runtime check to cast to type ClassMirror (dart:mirrors, line 171, col 10)
« tool/input_sdk/private/js_mirrors.dart ('K') | « tool/input_sdk/private/js_mirrors.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698