Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1252943008: Allow WebGL on Android if the GPU has it's own process (Take 2) (Closed)

Created:
5 years, 5 months ago by bajones
Modified:
5 years, 5 months ago
CC:
boliu, chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow WebGL on Android if the GPU has it's own process (Take 2) First attempt (https://codereview.chromium.org/1247093006/) was reverted due to failures on the Android bots. This is because the Android bots use content shell, not Chromium, to run the tests and that uses in-process GPU. As such the test were running without WebGL support. This patch adds back in the EXT_robusness exceptions, which allowed the bots to run WebGL content previously and won't appear to users as a regression. BUG=512992 TBR=mkwst@chromium.org Committed: https://crrev.com/e3677b649fff6a114d4c28de6afddef8cc5320db Cr-Commit-Position: refs/heads/master@{#340385}

Patch Set 1 #

Patch Set 2 : Added back robustness text to blacklist description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/gpu_control_list.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M gpu/config/gpu_control_list_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
bajones
Please take another look. Only difference between this and the previous CL is that this ...
5 years, 5 months ago (2015-07-24 21:20:37 UTC) #2
Ken Russell (switch to Gerrit)
+sievers I think this is the most compatible change. The fact that the bots broke ...
5 years, 5 months ago (2015-07-24 21:33:05 UTC) #4
aelias_OOO_until_Jul13
Good point about WebView. lgtm
5 years, 5 months ago (2015-07-24 22:47:42 UTC) #5
no sievers
lgtm. ContentShell uses in-process-gpu, whaat?
5 years, 5 months ago (2015-07-24 22:55:29 UTC) #6
Ken Russell (switch to Gerrit)
On 2015/07/24 22:55:29, sievers wrote: > lgtm. ContentShell uses in-process-gpu, whaat? This was a surprise ...
5 years, 5 months ago (2015-07-24 23:01:57 UTC) #7
bajones
TBRing Mike, since he's already approved the previous CL and gpu_messages hasn't changed since then.
5 years, 5 months ago (2015-07-24 23:21:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252943008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252943008/20001
5 years, 5 months ago (2015-07-24 23:22:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-25 00:42:04 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e3677b649fff6a114d4c28de6afddef8cc5320db Cr-Commit-Position: refs/heads/master@{#340385}
5 years, 5 months ago (2015-07-25 00:42:57 UTC) #12
Mike West
5 years, 5 months ago (2015-07-25 04:43:00 UTC) #13
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698