Issue 125293004: Merge 12729 "[PDF] Fix clipping in xfermode improvement."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125293004: Merge 12729 "[PDF] Fix clipping in xfermode improvement." (Closed)

Created:
6 years, 11 months ago by vandebo (ex-Chrome)

Modified:
6 years, 11 months ago

Reviewers:
commit-bot: I haz the power

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/branches/chrome/m33_1750/

Visibility:
Public.

Merge 12729 "[PDF] Fix clipping in xfermode improvement." > [PDF] Fix clipping in xfermode improvement. > > In some cases, the wrong clip (src clip instead of initial clip) was used. > Switch almost exclusively to initial clip because it is safe and generates a smaller result. > > BUG=chromium:328009 > R=reed@google.com, bungeman@google.com > > Author: vandebo@chromium.org > > Review URL: https://codereview.chromium.org/116423004 TBR=vandebo@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=12934

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -21 lines)			Patch
	M	gm/xfermodes.cpp	View		2 chunks	+12 lines, -1 line	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		6 chunks	+18 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r12934.