WebUSB bindings part 3

WebUSB bindings part 3

This adds USBConfiguration and USBInterface interfaces,
and also fills out the rest of the WebUSBDeviceInfo structure.

BUG=492204
R=reillyg@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199941

[Reilly Grant (use Gerrit), 2015-08-03 23:00:50]

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
File Source/modules/webusb/USBConfiguration.cpp (right):

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
Source/modules/webusb/USBConfiguration.cpp:21: if (configurationIndex <
device->info().configurations.size())
Since this constructor will be called from scripts without insight into the
order of configuration descriptors read from the device this should take a
configurationValue and validate it before returning.

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
File Source/modules/webusb/USBInterface.cpp (right):

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
Source/modules/webusb/USBInterface.cpp:20: if (interfaceIndex <
configuration->info().interfaces.size())
Since this constructor will be called from scripts without insight into the set
of interface descriptors read from the device this should take an
interfaceNumber and validate it before returning.

https://codereview.chromium.org/1252913014/diff/20001/public/platform/modules...
File public/platform/modules/webusb/WebUSBDeviceInfo.h (right):

https://codereview.chromium.org/1252913014/diff/20001/public/platform/modules...
public/platform/modules/webusb/WebUSBDeviceInfo.h:60:
WebVector<AlternateInterface> alternates;
Leave out AlternateInterface and Endpoint until the next patch?

[Ken Rockot(use gerrit already), 2015-08-04 00:51:26]

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
File Source/modules/webusb/USBConfiguration.cpp (right):

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
Source/modules/webusb/USBConfiguration.cpp:21: if (configurationIndex <
device->info().configurations.size())
On 2015/08/03 23:00:50, reillyg wrote:
> Since this constructor will be called from scripts without insight into the
> order of configuration descriptors read from the device this should take a
> configurationValue and validate it before returning.

Done.

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
File Source/modules/webusb/USBInterface.cpp (right):

https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/U...
Source/modules/webusb/USBInterface.cpp:20: if (interfaceIndex <
configuration->info().interfaces.size())
On 2015/08/03 23:00:50, reillyg wrote:
> Since this constructor will be called from scripts without insight into the
set
> of interface descriptors read from the device this should take an
> interfaceNumber and validate it before returning.

Done.

https://codereview.chromium.org/1252913014/diff/20001/public/platform/modules...
File public/platform/modules/webusb/WebUSBDeviceInfo.h (right):

https://codereview.chromium.org/1252913014/diff/20001/public/platform/modules...
public/platform/modules/webusb/WebUSBDeviceInfo.h:60:
WebVector<AlternateInterface> alternates;
On 2015/08/03 23:00:50, reillyg wrote:
> Leave out AlternateInterface and Endpoint until the next patch?

Done.

[Reilly Grant (use Gerrit), 2015-08-04 00:58:28]

LGTM aside for a preference for C++11 style for loops.

[Ken Rockot(use gerrit already), 2015-08-04 01:01:33]

On 2015/08/04 00:58:28, reillyg wrote:
> LGTM aside for a preference for C++11 style for loops.

yeah, but we need the index for the real constructors D:

[Ken Rockot(use gerrit already), 2015-08-04 01:01:36]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-08-04 01:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252913014/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252913014/40001

[commit-bot: I haz the power, 2015-08-04 02:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 02:14:33]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/72429)

[Ken Rockot(use gerrit already), 2015-08-04 05:21:51]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-08-04 05:21:51]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/1252913014/#ps60001
(title: "update expeced interface listing")

[commit-bot: I haz the power, 2015-08-04 05:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252913014/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252913014/60001

[commit-bot: I haz the power, 2015-08-04 06:02:28]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199941