Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1252913014: WebUSB bindings part 3 (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebUSB bindings part 3 This adds USBConfiguration and USBInterface interfaces, and also fills out the rest of the WebUSBDeviceInfo structure. BUG=492204 R=reillyg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199941

Patch Set 1 #

Patch Set 2 : set-upstream #

Total comments: 6

Patch Set 3 : better constructors #

Patch Set 4 : update expeced interface listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -0 lines) Patch
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 chunks +7 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.cpp View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConfiguration.idl View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBDevice.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBDevice.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/modules/webusb/USBDevice.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.cpp View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBInterface.idl View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M public/platform/modules/webusb/WebUSBDeviceInfo.h View 1 2 2 chunks +39 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (4 generated)
Ken Rockot(use gerrit already)
5 years, 4 months ago (2015-08-03 22:52:43 UTC) #1
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/USBConfiguration.cpp File Source/modules/webusb/USBConfiguration.cpp (right): https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/USBConfiguration.cpp#newcode21 Source/modules/webusb/USBConfiguration.cpp:21: if (configurationIndex < device->info().configurations.size()) Since this constructor will be ...
5 years, 4 months ago (2015-08-03 23:00:50 UTC) #2
Reilly Grant (use Gerrit)
5 years, 4 months ago (2015-08-03 23:00:51 UTC) #3
Reilly Grant (use Gerrit)
5 years, 4 months ago (2015-08-03 23:00:51 UTC) #4
Reilly Grant (use Gerrit)
5 years, 4 months ago (2015-08-03 23:00:52 UTC) #5
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/USBConfiguration.cpp File Source/modules/webusb/USBConfiguration.cpp (right): https://codereview.chromium.org/1252913014/diff/20001/Source/modules/webusb/USBConfiguration.cpp#newcode21 Source/modules/webusb/USBConfiguration.cpp:21: if (configurationIndex < device->info().configurations.size()) On 2015/08/03 23:00:50, reillyg wrote: ...
5 years, 4 months ago (2015-08-04 00:51:26 UTC) #6
Reilly Grant (use Gerrit)
LGTM aside for a preference for C++11 style for loops.
5 years, 4 months ago (2015-08-04 00:58:28 UTC) #7
Ken Rockot(use gerrit already)
On 2015/08/04 00:58:28, reillyg wrote: > LGTM aside for a preference for C++11 style for ...
5 years, 4 months ago (2015-08-04 01:01:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252913014/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252913014/40001
5 years, 4 months ago (2015-08-04 01:01:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/72429)
5 years, 4 months ago (2015-08-04 02:14:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252913014/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252913014/60001
5 years, 4 months ago (2015-08-04 05:22:09 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 06:02:28 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199941

Powered by Google App Engine
This is Rietveld 408576698