Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1252913009: Fix compile error with Windows clang. (Closed)

Created:
5 years, 4 months ago by Yoshisato Yanagisawa
Modified:
5 years, 3 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Fix compile error with Windows clang. This change fixes the following errors shown during compile with Windows clang: error: cannot pass non-trivial object of type 'ATL::CComBSTR' to variadic function; expected type from format string was 'wchar_t *' [-Wnon-pod-varargs] BUG=https://code.google.com/p/google-breakpad/issues/detail?id=662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M common/windows/pdb_source_line_writer.cc View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Yoshisato Yanagisawa
Hi, Let me send change list to fix Windows clang compile error. I will send ...
5 years, 4 months ago (2015-07-29 02:01:16 UTC) #2
Yoshisato Yanagisawa
Note that when I tried to follow https://code.google.com/p/google-breakpad/source/browse/trunk/README However, I got 500 Server error with ...
5 years, 4 months ago (2015-07-29 02:02:59 UTC) #3
Yoshisato Yanagisawa
5 years, 4 months ago (2015-07-29 02:03:11 UTC) #4
Yoshisato Yanagisawa
Do you see some problems with this change?
5 years, 4 months ago (2015-08-19 03:33:36 UTC) #5
Will Harris
On 2015/08/19 03:33:36, Yoshisato Yanagisawa wrote: > Do you see some problems with this change? ...
5 years, 4 months ago (2015-08-19 03:35:22 UTC) #6
Yoshisato Yanagisawa
thanks.
5 years, 4 months ago (2015-08-19 03:39:47 UTC) #7
Mark Mentovai
LGTM
5 years, 4 months ago (2015-08-19 22:24:55 UTC) #9
Will Harris
On 2015/08/19 22:24:55, Mark Mentovai - out til August wrote: > LGTM committed in https://codereview.chromium.org/1307463003/
5 years, 4 months ago (2015-08-19 22:28:52 UTC) #10
Yoshisato Yanagisawa
5 years, 3 months ago (2015-08-27 03:00:25 UTC) #11
I noticed that this change may cause dump_syms crash in Win32. (I am not sure
why I do not see the issue on Win64).
I am fixing.

Powered by Google App Engine
This is Rietveld 408576698