Enable gdb-jit for PPC64 on Linux (both big-endian and little-endian).

Enable gdb-jit for PPC64 on Linux (both big-endian and little-endian).

R=danno@chromium.org, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com

BUG=

Committed: https://crrev.com/8d2eec506f6aa78d99ff78926d283a0625bc4c02
Cr-Commit-Position: refs/heads/master@{#29984}

[dstence, 2015-07-28 16:53:02]

dstence@us.ibm.com changed reviewers:
+ danno@chromium.org

[dstence, 2015-08-03 14:16:58]

On 2015/07/28 16:21:53, dstence wrote:

Still waiting for review.

[Jakob Kummerow, 2015-08-03 16:03:36]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2015-08-03 16:03:36]

LGTM with nits.

https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):

https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode396
src/gdb-jit.cc:396: 
nit: why this change?

https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode678
src/gdb-jit.cc:678: // Join the next 4 lines, omitting the spaces and
double-slashes.
Links are exempt from the 80-col policy; however this one is very long indeed,
and sticking wtih 80-col is nice. How about a goo.gl shortcut?

Or you can leave it as is, I'm fine with either.

https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode700
src/gdb-jit.cc:700: 
nit: why this change?

https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode1149
src/gdb-jit.cc:1149: w->Write<uint8_t>(DW_OP_reg31);  // The frame pointer is
here on PPC64
nit: trailing full stop please.

[dstence, 2015-08-03 17:06:23]

On 2015/08/03 16:03:36, Jakob wrote:
> LGTM with nits.
> 
> https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc
> File src/gdb-jit.cc (right):
> 
> https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode396
> src/gdb-jit.cc:396: 
> nit: why this change?
> 
> https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode678
> src/gdb-jit.cc:678: // Join the next 4 lines, omitting the spaces and
> double-slashes.
> Links are exempt from the 80-col policy; however this one is very long indeed,
> and sticking wtih 80-col is nice. How about a goo.gl shortcut?
> 
> Or you can leave it as is, I'm fine with either.
> 
> https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode700
> src/gdb-jit.cc:700: 
> nit: why this change?
> 
> https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode1149
> src/gdb-jit.cc:1149: w->Write<uint8_t>(DW_OP_reg31);  // The frame pointer is
> here on PPC64
> nit: trailing full stop please.

Addressed issues in Patchset 2.

[dstence, 2015-08-03 17:11:18]

The CQ bit was checked by dstence@us.ibm.com

[dstence, 2015-08-03 17:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1252913007/#ps20001
(title: "Correct white-space issues.")

[commit-bot: I haz the power, 2015-08-03 17:11:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252913007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252913007/20001

[commit-bot: I haz the power, 2015-08-03 18:02:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-03 18:02:41]

Patchset 2 (id:??) landed as
https://crrev.com/8d2eec506f6aa78d99ff78926d283a0625bc4c02
Cr-Commit-Position: refs/heads/master@{#29984}