Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1252903002: X87: Unify "runtime-style" IC functions with Runtime intrinsics (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Unify "runtime-style" IC functions with Runtime intrinsics port bc8041dc2b4c8431c5c2476496acd3b7b8b3f61e (r29811). original commit message: Previous to this CL, ICs used a slightly different code idiom to get to C++ code from generated code than runtime intrinsics, using an IC_Utility class that in essence provided exactly the same functionality as Runtime::FunctionForId, but in its own quirky way. This CL unifies the two mechanisms, folding IC_Utility away by making all IC entry points in C++ code, e.g. IC miss handlers, full-fledged runtime intrinsics. This makes it possible to eliminate a bunch of ad-hoc declarations and adapters that the IC system had to needlessly re-invent. As a bonus and the original reason for this yak-shave: IC-related C++ runtime functions are now callable from TurboFan. BUG= Committed: https://crrev.com/2571c69dcb8bbb3eeb2bce86ef46cbe83c562227 Cr-Commit-Position: refs/heads/master@{#29837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -42 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 7 chunks +9 lines, -18 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M src/x87/debug-x87.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 09:27:17 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 09:32:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252903002/1
5 years, 5 months ago (2015-07-24 09:32:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 09:58:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 09:59:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2571c69dcb8bbb3eeb2bce86ef46cbe83c562227
Cr-Commit-Position: refs/heads/master@{#29837}

Powered by Google App Engine
This is Rietveld 408576698