Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12529029: Avoid the possibility of future conflict with another address-of-static due to COMDAT folding. (Closed)

Created:
7 years, 9 months ago by Jói
Modified:
7 years, 9 months ago
Reviewers:
kaiwang
CC:
chromium-reviews
Visibility:
Public.

Description

Avoid the possibility of future conflict with another address-of-static due to COMDAT folding. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190035

Patch Set 1 #

Patch Set 2 : Reduce scope of static, merge to head. #

Patch Set 3 : Merge to head mainly to get a clean CQ start. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/user_prefs/user_prefs.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jói
7 years, 9 months ago (2013-03-20 19:28:21 UTC) #1
kaiwang
lgtm
7 years, 9 months ago (2013-03-20 20:41:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/1
7 years, 9 months ago (2013-03-20 20:54:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=21964
7 years, 9 months ago (2013-03-21 07:39:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/1
7 years, 9 months ago (2013-03-21 11:36:35 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-21 15:14:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/32001
7 years, 9 months ago (2013-03-21 22:15:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/32001
7 years, 9 months ago (2013-03-22 18:20:32 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on linux_aura HTTP Error 400: Bad Request
7 years, 9 months ago (2013-03-23 14:00:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/52001
7 years, 9 months ago (2013-03-23 14:01:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12529029/52001
7 years, 9 months ago (2013-03-23 14:58:16 UTC) #11
Jói
7 years, 9 months ago (2013-03-23 17:25:00 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 manually as r190035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698