Context menu on views must show on mouse down for non-WIN.

ui/views/controls/menu/menu_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_runner.h"
 
 #include <set>
 
 #include "base/metrics/histogram.h"
 #include "ui/views/controls/button/menu_button.h"
@@ skipping 323 matching lines @@
     display_change_listener_.reset(
         internal::DisplayChangeListener::Create(parent, this));
   }
   if ((types & MenuRunner::CONTEXT_MENU) &&
       parent &&
       parent->GetCurrentEvent() &&
       !MenuItemView::IsBubble(anchor))
     anchor = parent->GetCurrentEvent()->IsGestureEvent() ?
         MenuItemView::BOTTOMCENTER : MenuItemView::TOPLEFT;
 
+  // If we are shown on mouse press, we will eat the subsequent mouse down and
+  // the parent widget will not be able to reset its state (it might have mouse
+  // capture from the mouse down). So we clear its state here.
+  if (parent && parent->GetRootView())
+    parent->GetRootView()->SetMouseHandler(NULL);

[sky, 2013/03/20 21:35:53]

This means a view isn't going to get a mouse exited. Are you sure all views that
have context menus are set up to deal correctly with this?

[varunjain, 2013/03/20 22:05:52]

SetMouseHandler(NULL) does not reset the mouse_move_handler in RootView. So the
view should still get exit. More generally speaking, the functionality of
RootView::OnMouseMove and RootView::OnMouseExit should not change after this.

+
   return holder_->RunMenuAt(parent, button, bounds, anchor, types);
 }
 
 bool MenuRunner::IsRunning() const {
   return holder_->running();
 }
 
 void MenuRunner::Cancel() {
   holder_->Cancel();
 }
 
 base::TimeDelta MenuRunner::closing_event_time() const {
   return holder_->closing_event_time();
 }
 
 }  // namespace views