Collect type feedback for fields.

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 1362 matching lines @@
 #define DEOPT_REASON_ID_TO_TEXT(name) case kDeopt##name: return #name;
 DEOPT_REASONS(DEOPT_REASON_ID_TO_TEXT)
 #undef DEOPT_REASON_ID_TO_TEXT
     default:
       UNREACHABLE();
       return "";
   }
 }
 
 
-static void DeoptimizeAt(const Code& optimized_code, uword pc) {
+void DeoptimizeAt(const Code& optimized_code, uword pc) {

[srdjan, 2013/03/18 18:54:35]

ASSERT optimized code is optimized code?

[Vyacheslav Egorov (Google), 2013/03/18 19:41:18]

Done.

   intptr_t deopt_reason = kDeoptUnknown;
   const DeoptInfo& deopt_info =
       DeoptInfo::Handle(optimized_code.GetDeoptInfoAtPc(pc, &deopt_reason));
   ASSERT(!deopt_info.IsNull());
   const Function& function = Function::Handle(optimized_code.function());
   const Code& unoptimized_code = Code::Handle(function.unoptimized_code());
   ASSERT(!unoptimized_code.IsNull());
   // The switch to unoptimized code may have already occured.
   if (function.HasOptimizedCode()) {
     function.SwitchToUnoptimizedCode();
@@ skipping 332 matching lines @@
   } else if (remainder < 0.0) {
     if (right < 0) {
       remainder -= right;
     } else {
       remainder += right;
     }
   }
   return remainder;
 }
 
+
+// Update global type feedback recorded for a field recording the assignment
+// of the given value.
+//   Arg0: Field object;
+//   Arg1: Value that is being stored.
+DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
+  ASSERT(arguments.ArgCount() == kUpdateFieldCidRuntimeEntry.argument_count());
+  const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
+  const Object& value_cid = Object::Handle(arguments.ArgAt(1));

[srdjan, 2013/03/18 18:54:35]

s/value_cid/value/ ?

[Vyacheslav Egorov (Google), 2013/03/18 19:41:18]

Done.

+
+  field.UpdateCid(Class::Handle(value_cid.clazz()).id());
+}
+
 }  // namespace dart