Collect type feedback for fields.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/locations.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
+#include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 #define __ compiler->assembler()->
 
 namespace dart {
 
 DECLARE_FLAG(int, optimization_counter_threshold);
 DECLARE_FLAG(bool, propagate_ic_data);
 
@@ skipping 1475 matching lines @@
       break;
     case kFloat64ArrayCid:
       __ movsd(element_address, locs()->in(2).fpu_reg());
       break;
     default:
       UNREACHABLE();
   }
 }
 
 
+LocationSummary* GuardFieldInstr::MakeLocationSummary() const {
+  const intptr_t kNumInputs = 1;
+  LocationSummary* summary =
+      new LocationSummary(kNumInputs, 0, LocationSummary::kNoCall);
+  summary->set_in(0, Location::RequiresRegister());
+  if (value()->Type()->ToCid() == kDynamicCid) {
+    summary->AddTemp(Location::RequiresRegister());
+  }
+  if (field().guarded_cid() == kIllegalCid) {
+    summary->AddTemp(Location::RequiresRegister());
+  }
+  return summary;
+}
+
+
+static void PushCid(FlowGraphCompiler* compiler, const Immediate& imm) {
+  __ pushl(Immediate(Smi::RawValue(imm.value())));
+}
+
+
+static void PushCid(FlowGraphCompiler* compiler, Register reg) {
+  __ SmiTag(reg);
+  __ pushl(reg);
+}
+
+
+template<typename ValueCidOperandType>
+static void EmitCidGuardInit(FlowGraphCompiler* compiler,
+                                       ValueCidOperandType value_cid,
+                                       const Immediate& field_cid,
+                                       const Immediate& nullability,
+                                       Label* deopt,
+                                       Label* ok) {
+  // nothing to do.
+}
+
+
+template<typename ValueCidOperandType>
+static void EmitCidGuardInit(FlowGraphCompiler* compiler,
+                             ValueCidOperandType value_cid,
+                             const FieldAddress& field_cid,
+                                       const FieldAddress& nullability,
+                                       Label* deopt,
+                                       Label* ok) {
+  // Check if field is initialized for the first time.
+  Label fail;
+  __ cmpl(field_cid, Immediate(kIllegalCid));
+  __ j(NOT_EQUAL, (deopt != NULL) ? deopt : &fail);
+  __ movl(field_cid, value_cid);
+  __ movl(nullability, value_cid);
+  __ jmp(ok);
+  if (deopt == NULL) {
+    __ Bind(&fail);
+  }
+}
+
+
+static void CompareJump(FlowGraphCompiler* compiler,
+                        Condition cond,
+                        const Immediate& left,
+                        const Immediate& right,
+                        Label* target) {
+  if ((left.value() == right.value()) && (cond == EQUAL)) {
+    __ jmp(target);
+  } else if ((left.value() != right.value()) && cond == NOT_EQUAL) {
+    __ jmp(target);
+  }
+}
+
+
+static void CompareJump(FlowGraphCompiler* compiler,
+                        Condition cond,
+                        Immediate left,
+                        Register right,
+                        Label* target) {
+  ASSERT((cond == EQUAL) || (cond == NOT_EQUAL));
+  __ cmpl(right, left);
+  __ j(cond, target);
+}
+
+
+template<typename LeftT, typename RightT>

[Kevin Millikin (Google), 2013/03/12 12:14:56]

Spell out Type like below, or at least be uniform.

[Vyacheslav Egorov (Google), 2013/03/12 16:54:40]

Done.

+static void CompareJump(FlowGraphCompiler* compiler,
+                        Condition cond,
+                        LeftT left,
+                        RightT right,
+                        Label* target) {
+  __ cmpl(left, right);
+  __ j(cond, target);
+}
+
+
+template<typename ValueCidOperandType,
+         typename FieldCidOperandType,
+         typename FieldNullabilityOperandType>
+static void EmitCidGuard(FlowGraphCompiler* compiler,
+                                   const Field& field,

[Kevin Millikin (Google), 2013/03/12 12:14:56]

The templates are kind of messy because you have to track data and type flow
through here to figure out what code is actually generated.

I don't have any better solution.

You could at least align the parameters properly here and below.

[Vyacheslav Egorov (Google), 2013/03/12 16:54:40]

Done.

+                                   ValueCidOperandType value_cid,
+                                   FieldCidOperandType field_cid,
+                                   FieldNullabilityOperandType nullability,
+                                   Label* deopt) {
+  Label ok, update;
+  CompareJump(compiler, EQUAL, field_cid, value_cid, &ok);
+  if ((deopt != NULL) && (field.guarded_cid() != kIllegalCid)) {
+    CompareJump(compiler, NOT_EQUAL, nullability, value_cid, deopt);
+  } else {
+    CompareJump(compiler, EQUAL, nullability, value_cid, &ok);
+  }
+
+  EmitCidGuardInit(compiler, value_cid, field_cid, nullability, deopt, &ok);
+
+  if (deopt == NULL) {
+    // Switch field's cid to dynamic and notify runtime.
+    CompareJump(compiler, EQUAL, field_cid, Immediate(kDynamicCid), &ok);
+    __ PushObject(field);
+    PushCid(compiler, value_cid);
+    __ CallRuntime(kUpdateFieldCidRuntimeEntry);
+    __ Drop(2);
+  }
+
+  __ Bind(&ok);
+}
+
+
+template<typename FieldCidOperandType, typename FieldNullabilityOperandType>
+static void EmitCidGuard(FlowGraphCompiler* compiler,
+                                  const Field& field,
+                                   intptr_t value_cid,
+                                   Register value_cid_reg,
+                                   FieldCidOperandType field_cid,
+                                   FieldNullabilityOperandType nullability,
+                                   Label* deopt) {
+  if (value_cid == kDynamicCid) {
+    EmitCidGuard(compiler, field, value_cid_reg, field_cid, nullability, deopt);
+  } else {
+    EmitCidGuard(compiler,
+                 field,
+                 Immediate(value_cid),
+                 field_cid,
+                 nullability,
+                 deopt);
+  }
+}
+
+
+static void EmitFieldGuard(FlowGraphCompiler* compiler,
+                           Register value_reg,
+                           const Field& field,
+                           intptr_t value_cid,
+                           Register value_cid_reg,
+                           intptr_t field_cid,
+                           intptr_t nullability,
+                           Register field_reg,
+                           Label* deopt) {
+  if (value_cid == kDynamicCid) {
+    Label not_smi, cid_loaded;
+    __ testl(value_reg, Immediate(kSmiTagMask));
+    __ j(NOT_ZERO, &not_smi, Assembler::kNearJump);
+    __ movl(value_cid_reg, Immediate(kSmiCid));
+    __ jmp(&cid_loaded);
+    __ Bind(&not_smi);
+    __ LoadClassId(value_cid_reg, value_reg);
+    __ Bind(&cid_loaded);
+  }
+
+  if (field_cid == kIllegalCid) {
+    __ LoadObject(field_reg, Field::ZoneHandle(field.raw()));
+    EmitCidGuard(compiler,
+                 field,
+                 value_cid,
+                 value_cid_reg,
+                 FieldAddress(field_reg, Field::guarded_cid_offset()),
+                 FieldAddress(field_reg, Field::is_nullable_offset()),
+                 deopt);
+  } else {
+    EmitCidGuard(compiler,
+                 field,
+                 value_cid,
+                 value_cid_reg,
+                 Immediate(field_cid),
+                 Immediate(nullability),
+                 deopt);
+  }
+}
+
+
+void GuardFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  const intptr_t value_cid = value()->Type()->ToCid();
+  const intptr_t field_cid = field().guarded_cid();
+  const intptr_t nullability = field().is_nullable() ? kNullCid : kIllegalCid;
+
+  Register value_reg = locs()->in(0).reg();
+
+  Register value_cid_reg = (value_cid == kDynamicCid) ?
+      locs()->temp(0).reg() : kNoRegister;
+
+  Label* deopt = compiler->is_optimizing() && CanDeoptimize() ?
+      compiler->AddDeoptStub(deopt_id(), kDeoptStoreInstanceField) : NULL;
+
+  if ((deopt != NULL) && (field_cid != kIllegalCid)) {
+    if (value_cid != kDynamicCid) {
+      ASSERT(field_cid != value_cid);
+      __ jmp(deopt);
+      return;
+    }
+
+    if (field_cid == kSmiCid) {
+      __ testl(value_reg, Immediate(kSmiTagMask));
+    } else {
+      ASSERT(value_cid_reg != kNoRegister);
+      __ testl(value_reg, Immediate(kSmiTagMask));
+      __ j(ZERO, deopt);
+      __ LoadClassId(value_cid_reg, value_reg);
+      __ cmpl(value_cid_reg, Immediate(field_cid));
+    }
+
+    if (field().is_nullable()) {
+      Label ok;
+      __ j(EQUAL, &ok);
+      const Immediate& raw_null =
+          Immediate(reinterpret_cast<intptr_t>(Object::null()));
+      __ cmpl(value_reg, raw_null);
+      __ j(NOT_EQUAL, deopt);
+      __ Bind(&ok);
+    } else {
+      __ j(NOT_EQUAL, deopt);
+    }
+
+    return;
+  }
+
+  Register field_reg = (field_cid == kIllegalCid) ?
+      locs()->temp(1).reg() : kNoRegister;
+
+  EmitFieldGuard(compiler,
+                 value_reg,
+                 field(),
+                 value_cid, value_cid_reg,
+                 field_cid, nullability, field_reg,
+                 deopt);
+}
+
+
 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 2;
   const intptr_t num_temps =  0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, num_temps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresRegister());
-  summary->set_in(1, ShouldEmitStoreBarrier()
-                       ? Location::WritableRegister()
-                       : Location::RegisterOrConstant(value()));
+  if (ShouldEmitStoreBarrier() || should_emit_field_guard()) {
+    summary->set_in(1, Location::WritableRegister());
+  } else {
+    summary->set_in(1, Location::RegisterOrConstant(value()));
+  }
+
+  if (should_emit_field_guard()) {
+    summary->AddTemp(Location::RequiresRegister());
+    summary->AddTemp(Location::RequiresRegister());
+  }
+
   return summary;
 }
 
 
 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register instance_reg = locs()->in(0).reg();
+
+  if (should_emit_field_guard()) {
+    ASSERT(!compiler->is_optimizing());
+    Register value_reg = locs()->in(1).reg();
+    Register value_cid_reg = locs()->temp(0).reg();
+    Register field_reg = locs()->temp(1).reg();
+
+    __ pushl(instance_reg);
+    __ pushl(value_reg);
+    EmitFieldGuard(compiler,
+                          value_reg,
+                          field(),
+                          kDynamicCid,
+                          value_cid_reg,
+                          kIllegalCid,
+                          kIllegalCid,
+                          field_reg,
+                          NULL);
+    __ popl(value_reg);
+    __ popl(instance_reg);
+  }
+
   if (ShouldEmitStoreBarrier()) {
     Register value_reg = locs()->in(1).reg();
     __ StoreIntoObject(instance_reg,
         FieldAddress(instance_reg, field().Offset()), value_reg);
   } else {
     if (locs()->in(1).IsConstant()) {
       __ StoreIntoObjectNoBarrier(
           instance_reg,
           FieldAddress(instance_reg, field().Offset()),
           locs()->in(1).constant());
@@ skipping 1285 matching lines @@
 }
 
 
 void BranchInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   comparison()->EmitBranchCode(compiler, this);
 }
 
 
 LocationSummary* CheckClassInstr::MakeLocationSummary() const {
   const intptr_t kNumInputs = 1;
-  const intptr_t kNumTemps = 1;
+  const intptr_t kNumTemps = 0;
   LocationSummary* summary =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   summary->set_in(0, Location::RequiresRegister());
-  summary->set_temp(0, Location::RequiresRegister());
+  if (!null_check()) {
+    summary->AddTemp(Location::RequiresRegister());
+  }
   return summary;
 }
 
 
 void CheckClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  if (null_check()) {
+    Label* deopt = compiler->AddDeoptStub(deopt_id(),
+                                          kDeoptCheckClass);
+    const Immediate& raw_null =
+        Immediate(reinterpret_cast<intptr_t>(Object::null()));
+    __ cmpl(locs()->in(0).reg(), raw_null);
+    __ j(EQUAL, deopt);
+    return;
+  }
+
   ASSERT((unary_checks().GetReceiverClassIdAt(0) != kSmiCid) ||
          (unary_checks().NumberOfChecks() > 1));
   Register value = locs()->in(0).reg();
   Register temp = locs()->temp(0).reg();
   Label* deopt = compiler->AddDeoptStub(deopt_id(),
                                         kDeoptCheckClass);
   Label is_ok;
   intptr_t cix = 0;
   if (unary_checks().GetReceiverClassIdAt(cix) == kSmiCid) {
     __ testl(value, Immediate(kSmiTagMask));
@@ skipping 703 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32