Collect type feedback for fields.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
@@ skipping 2577 matching lines @@
   Append(for_value);
   Value* store_value = for_value.value();
   if (FLAG_enable_type_checks) {
     const AbstractType& type = AbstractType::ZoneHandle(node->field().type());
     const String& dst_name = String::ZoneHandle(node->field().name());
     store_value = BuildAssignableValue(node->value()->token_pos(),
                                        store_value,
                                        type,
                                        dst_name);
   }
   StoreInstanceFieldInstr* store = new StoreInstanceFieldInstr(

[Kevin Millikin (Google), 2013/03/12 12:14:56]

Thanks, I guess.  But the dangling "(" is the really ugly part to my eyes (a
symptom of breaking at a higher precedence operator when breaking at a lower
precedence one would do).  Try:

StoreInstanceFieldInstr* store =
    new StoreInstanceFieldInstr(node->field(),
                                for_instance.value(),
                                store_value,
                                kEmitStoreBarrier);

[Vyacheslav Egorov (Google), 2013/03/12 16:54:40]

Done.

-      node->field(), for_instance.value(), store_value, kEmitStoreBarrier);
+      node->field(),
+      for_instance.value(),
+      store_value,
+      kEmitStoreBarrier);
   ReturnDefinition(store);
 }
 
 
 // StoreInstanceFieldNode does not return result.
 void ValueGraphVisitor::VisitStoreInstanceFieldNode(
     StoreInstanceFieldNode* node) {
   UNIMPLEMENTED();
 }
 
@@ skipping 689 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart