Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4092)

Unified Diff: src/spaces.cc

Issue 12529005: Ignore evacuation canditate pages when verifying spaces. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index 1861c5340391d50db9d7c2ac3e51ce6dd6f2d0da..a28720bff0527d4f6d4d69e3b8e8c4a323536372 100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -100,14 +100,12 @@ void HeapObjectIterator::Initialize(PagedSpace* space,
// We have hit the end of the page and should advance to the next block of
// objects. This happens at the end of the page.
bool HeapObjectIterator::AdvanceToNextPage() {
- ASSERT(cur_addr_ == cur_end_);
if (page_mode_ == kOnePageOnly) return false;
Page* cur_page;
if (cur_addr_ == NULL) {
cur_page = space_->anchor();
} else {
cur_page = Page::FromAddress(cur_addr_ - 1);
- ASSERT(cur_addr_ == cur_page->area_end());
}
cur_page = cur_page->next_page();
if (cur_page == space_->anchor()) return false;
@@ -1104,7 +1102,9 @@ void PagedSpace::Verify(ObjectVisitor* visitor) {
Address end_of_previous_object = page->area_start();
Address top = page->area_end();
int black_size = 0;
- for (HeapObject* object = it.Next(); object != NULL; object = it.Next()) {
+ for (HeapObject* object = it.NextIgnoreEvacuationCandidates();
+ object != NULL;
+ object = it.NextIgnoreEvacuationCandidates()) {
CHECK(end_of_previous_object <= object->address());
// The first word should be a map, and we expect all map pointers to
« no previous file with comments | « src/spaces.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698