Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: src/mark-compact.cc

Issue 12529005: Ignore evacuation canditate pages when verifying spaces. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap.cc ('k') | src/spaces.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index cbb9dfbff0cef15f00545fdd142e41dc9e18db49..1c2791d277f2ed42116281b56ea45bb6db6a3654 100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -326,7 +326,9 @@ class VerifyNativeContextSeparationVisitor: public ObjectVisitor {
static void VerifyNativeContextSeparation(Heap* heap) {
HeapObjectIterator it(heap->code_space());
- for (Object* object = it.Next(); object != NULL; object = it.Next()) {
+ for (Object* object = it.NextIgnoreEvacuationCandidates();
+ object != NULL;
+ object = it.NextIgnoreEvacuationCandidates()) {
VerifyNativeContextSeparationVisitor visitor;
Code::cast(object)->CodeIterateBody(&visitor);
}
@@ -482,9 +484,9 @@ void MarkCompactCollector::VerifyMarkbitsAreClean() {
void MarkCompactCollector::VerifyWeakEmbeddedMapsInOptimizedCode() {
HeapObjectIterator code_iterator(heap()->code_space());
- for (HeapObject* obj = code_iterator.Next();
+ for (HeapObject* obj = code_iterator.NextIgnoreEvacuationCandidates();
obj != NULL;
- obj = code_iterator.Next()) {
+ obj = code_iterator.NextIgnoreEvacuationCandidates()) {
Code* code = Code::cast(obj);
if (code->kind() != Code::OPTIMIZED_FUNCTION) continue;
if (code->marked_for_deoptimization()) continue;
@@ -495,9 +497,9 @@ void MarkCompactCollector::VerifyWeakEmbeddedMapsInOptimizedCode() {
void MarkCompactCollector::VerifyOmittedPrototypeChecks() {
HeapObjectIterator iterator(heap()->map_space());
- for (HeapObject* obj = iterator.Next();
+ for (HeapObject* obj = iterator.NextIgnoreEvacuationCandidates();
obj != NULL;
- obj = iterator.Next()) {
+ obj = iterator.NextIgnoreEvacuationCandidates()) {
Map* map = Map::cast(obj);
map->VerifyOmittedPrototypeChecks();
}
« no previous file with comments | « src/heap.cc ('k') | src/spaces.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698