Source/core/layout/MultiColumnFragmentainerGroup.h - Issue 1252863005: Simplify MultiColumnFragmentainerGroup::collectLayerFragments().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 1252863005: Simplify MultiColumnFragmentainerGroup::collectLayerFragments(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/MultiColumnFragmentainerGroup.h

diff --git a/Source/core/layout/MultiColumnFragmentainerGroup.h b/Source/core/layout/MultiColumnFragmentainerGroup.h

index 81fdcc3a9d3974a51eaabe097b2051fb542482cc..04f4534a8cf76cc1d6cba3204fbd214f1f6e407f 100644

--- a/Source/core/layout/MultiColumnFragmentainerGroup.h

+++ b/Source/core/layout/MultiColumnFragmentainerGroup.h

@@ -86,7 +86,7 @@ private:

LayoutRect columnRectAt(unsigned columnIndex) const;

LayoutUnit logicalTopInFlowThreadAt(unsigned columnIndex) const { return m_logicalTopInFlowThread + columnIndex * m_columnHeight; }

LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;

- LayoutRect flowThreadPortionOverflowRect(const LayoutRect& flowThreadPortion, unsigned columnIndex, unsigned columnCount, LayoutUnit columnGap) const;

+ LayoutRect flowThreadPortionOverflowRectAt(unsigned columnIndex) const;

enum ColumnIndexCalculationMode {

ClampToExistingColumns, // Stay within the range of already existing columns.

« no previous file with comments | « no previous file | Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('j') | Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('J')