Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 1252863005: Simplify MultiColumnFragmentainerGroup::collectLayerFragments(). (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Simplify MultiColumnFragmentainerGroup::collectLayerFragments(). No need to do so much stuff on our own in there, when we already have methods that can do it for us. This is just clean-up; no behavioral changes intended. R=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/1295b7ec94e0e05cd85c7e96862939d61093523f git-svn-id: svn://svn.chromium.org/blink/trunk@199595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -50 lines) Patch
M Source/core/layout/MultiColumnFragmentainerGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.cpp View 4 chunks +11 lines, -49 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-07-28 11:05:36 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1252863005/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp File Source/core/layout/MultiColumnFragmentainerGroup.cpp (left): https://codereview.chromium.org/1252863005/diff/1/Source/core/layout/MultiColumnFragmentainerGroup.cpp#oldcode243 Source/core/layout/MultiColumnFragmentainerGroup.cpp:243: // Get the portion of the flow thread ...
5 years, 4 months ago (2015-07-28 18:48:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252863005/1
5 years, 4 months ago (2015-07-28 18:48:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199595
5 years, 4 months ago (2015-07-28 18:51:34 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:51:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1295b7ec94e0e05cd85c7e96862939d61093523f

Powered by Google App Engine
This is Rietveld 408576698