Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: runtime/vm/class_finalizer.cc

Issue 12528013: Add the typed data classes to the do not extend list. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/class_finalizer.h" 5 #include "vm/class_finalizer.h"
6 6
7 #include "vm/flags.h" 7 #include "vm/flags.h"
8 #include "vm/heap.h" 8 #include "vm/heap.h"
9 #include "vm/isolate.h" 9 #include "vm/isolate.h"
10 #include "vm/longjump.h" 10 #include "vm/longjump.h"
(...skipping 1525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1536 case kUint32ArrayCid: 1536 case kUint32ArrayCid:
1537 case kExternalUint32ArrayCid: 1537 case kExternalUint32ArrayCid:
1538 case kInt64ArrayCid: 1538 case kInt64ArrayCid:
1539 case kExternalInt64ArrayCid: 1539 case kExternalInt64ArrayCid:
1540 case kUint64ArrayCid: 1540 case kUint64ArrayCid:
1541 case kExternalUint64ArrayCid: 1541 case kExternalUint64ArrayCid:
1542 case kFloat32ArrayCid: 1542 case kFloat32ArrayCid:
1543 case kExternalFloat32ArrayCid: 1543 case kExternalFloat32ArrayCid:
1544 case kFloat64ArrayCid: 1544 case kFloat64ArrayCid:
1545 case kExternalFloat64ArrayCid: 1545 case kExternalFloat64ArrayCid:
1546 #define DO_NOT_EXTEND_TYPED_DATA_CLASSES(clazz) \
1547 case kTypedData##clazz##Cid: \
1548 case kExternalTypedData##clazz##Cid:
1549 CLASS_LIST_TYPED_DATA(DO_NOT_EXTEND_TYPED_DATA_CLASSES)
1550 #undef DO_NOT_EXTEND_TYPED_DATA_CLASSES
1546 case kDartFunctionCid: 1551 case kDartFunctionCid:
1547 case kWeakPropertyCid: 1552 case kWeakPropertyCid:
1548 is_error = true; 1553 is_error = true;
1549 break; 1554 break;
1550 default: { 1555 default: {
1551 // Special case: classes for which we don't have a known class id. 1556 // Special case: classes for which we don't have a known class id.
1552 if (super_type.IsDoubleType() || 1557 if (super_type.IsDoubleType() ||
1553 super_type.IsIntType() || 1558 super_type.IsIntType() ||
1554 super_type.IsStringType()) { 1559 super_type.IsStringType()) {
1555 is_error = true; 1560 is_error = true;
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
1789 void ClassFinalizer::ReportError(const char* format, ...) { 1794 void ClassFinalizer::ReportError(const char* format, ...) {
1790 va_list args; 1795 va_list args;
1791 va_start(args, format); 1796 va_start(args, format);
1792 const Error& error = Error::Handle( 1797 const Error& error = Error::Handle(
1793 Parser::FormatError(Script::Handle(), -1, "Error", format, args)); 1798 Parser::FormatError(Script::Handle(), -1, "Error", format, args));
1794 va_end(args); 1799 va_end(args);
1795 ReportError(error); 1800 ReportError(error);
1796 } 1801 }
1797 1802
1798 } // namespace dart 1803 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698