sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 12528004: Check for canBePrimitiveNumber when doing the intersection on a number type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 12528004: Check for canBePrimitiveNumber when doing the intersection on a number type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 19535)

+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)

@@ -439,7 +439,8 @@

HType leftType = left.instructionType;

HType rightType = right.instructionType;

- // We don't optimize on numbers to preserve the runtime semantics.

+ // Intersection of int and double return conflicting, so

+ // we don't optimize on numbers to preserve the runtime semantics.

if (!(left.isNumberOrNull() && right.isNumberOrNull()) &&

leftType.intersection(rightType, compiler).isConflicting()) {

return graph.addConstantBool(false, constantSystem);

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/types.dart » ('j') | no next file with comments »