Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: runtime/vm/intrinsifier_arm64.cc

Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add missing code on arm64 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm64.cc
diff --git a/runtime/vm/intrinsifier_arm64.cc b/runtime/vm/intrinsifier_arm64.cc
index 6cd4acf833ba79ce3ecac245d8b130ecd49e556d..8531f7fd85f38ee218d87ca74c3831939221025e 100644
--- a/runtime/vm/intrinsifier_arm64.cc
+++ b/runtime/vm/intrinsifier_arm64.cc
@@ -1736,8 +1736,14 @@ void Intrinsifier::StringBaseCharAt(Assembler* assembler) {
__ ldr(R1, Address(R0, R1), kUnsignedByte);
__ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols, kNoPP);
__ b(&fall_through, GE);
- __ LoadImmediate(
- R0, reinterpret_cast<uword>(Symbols::PredefinedAddress()), kNoPP);
+ const ExternalLabel symbols_label(
+ reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+ __ TagAndPushPP();
+ __ LoadPoolPointer(PP);
+ assembler->set_constant_pool_allowed(true);
+ __ LoadExternalLabel(R0, &symbols_label, kNotPatchable, PP);
+ assembler->set_constant_pool_allowed(false);
+ __ PopAndUntagPP();
__ AddImmediate(
R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize, kNoPP);
__ ldr(R0, Address(R0, R1, UXTX, Address::Scaled));
@@ -1751,8 +1757,12 @@ void Intrinsifier::StringBaseCharAt(Assembler* assembler) {
__ ldr(R1, Address(R0, R1), kUnsignedHalfword);
__ CompareImmediate(R1, Symbols::kNumberOfOneCharCodeSymbols, kNoPP);
__ b(&fall_through, GE);
- __ LoadImmediate(
- R0, reinterpret_cast<uword>(Symbols::PredefinedAddress()), kNoPP);
+ __ TagAndPushPP();
+ __ LoadPoolPointer(PP);
+ assembler->set_constant_pool_allowed(true);
+ __ LoadExternalLabel(R0, &symbols_label, kNotPatchable, PP);
+ assembler->set_constant_pool_allowed(false);
+ __ PopAndUntagPP();
__ AddImmediate(
R0, R0, Symbols::kNullCharCodeSymbolOffset * kWordSize, kNoPP);
__ ldr(R0, Address(R0, R1, UXTX, Address::Scaled));
« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698