runtime/vm/intermediate_language_arm.cc - Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1252703002: VM: Use object pool for loading Symbols::PredefinedAddress in intrinsic code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add missing code on arm64 Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index 05e9a8c9c52f79b972ebde7537f0a012aafa9be5..2d5b817e53dbe0187e11f985cdfe0506862c7a1e 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -979,6 +979,7 @@ LocationSummary* StringFromCharCodeInstr::MakeLocationSummary(Zone* zone,

void StringFromCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

+ ASSERT(compiler->is_optimizing());

const Register char_code = locs()->in(0).reg();

const Register result = locs()->out(0).reg();

__ LoadImmediate(result,

« no previous file with comments | « runtime/vm/assembler_x64.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »