Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/universe/universe.dart

Issue 12527006: A selector whose type mask is nullable, applies to methods on the null implementation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/compiler/implementation/compiler.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/language/null_method_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/universe/universe.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/universe/universe.dart (revision 19535)
+++ sdk/lib/_internal/compiler/implementation/universe/universe.dart (working copy)
@@ -507,7 +507,9 @@
return false;
}
- if (mask.isExact) {
+ if (mask.isNullable && compiler.backend.isNullImplementation(other)) {
+ return appliesUntyped(element, compiler);
+ } else if (mask.isExact) {
return hasElementIn(self, element) && appliesUntyped(element, compiler);
} else if (mask.isSubclass) {
return (hasElementIn(self, element)
« sdk/lib/_internal/compiler/implementation/compiler.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/language/null_method_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698