Oilpan: Schedule a precise GC when a page navigates

Source/platform/heap/ThreadState.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 167 matching lines @@
         // thread.
         ThreadTerminationGC,
     };
 
     // See setGCState() for possible state transitions.
     enum GCState {
         NoGCScheduled,
         IdleGCScheduled,
         PreciseGCScheduled,
         FullGCScheduled,
+        PageNavigationGCScheduled,

[haraken, 2015/08/11 07:43:08]

You need to add PageNavigationGCScheduled to ThreadState::setGCState. I think
the transition should be very similar to PreciseGCScheduled.

[keishi, 2015/08/11 08:12:58]

Please check the change to ThreadState::setGCState to see if I got this right.
PageNavigationGCScheduled can be set while NoGCScheduled or any of
theGCScheduled states and I didn't do completeSweep because I already do it in
ThreadState::schedulePageNavigationGCIfNeeded.

         GCRunning,
         EagerSweepScheduled,
         LazySweepScheduled,
         Sweeping,
         SweepingAndIdleGCScheduled,
         SweepingAndPreciseGCScheduled,
     };
 
     enum HeapIndices {
         EagerSweepHeapIndex = 0,
@@ skipping 124 matching lines @@
 #endif
 
     void didV8MajorGC();
 
     void performIdleGC(double deadlineSeconds);
     void performIdleLazySweep(double deadlineSeconds);
 
     void scheduleIdleGC();
     void scheduleIdleLazySweep();
     void schedulePreciseGC();
+    // estimatedRemovalRatio is the estimated ratio of objects that will be no
+    // longer necessary due to the navigation.
+    bool shouldSchedulePageNavigationGC(float estimatedRemovalRatio);

[haraken, 2015/08/11 07:43:08]

Move this declaration to the other shouldScheduleXXX methods.

[keishi, 2015/08/11 08:12:58]

Done.

+    void schedulePageNavigationGCIfNeeded(float estimatedRemovalRatio);
+    void schedulePageNavigationGC();
     void scheduleGCIfNeeded();
     void setGCState(GCState);
     GCState gcState() const;
     bool isInGC() const { return gcState() == GCRunning; }
     bool isSweepingInProgress() const
     {
         return gcState() == Sweeping || gcState() == SweepingAndPreciseGCScheduled || gcState() == SweepingAndIdleGCScheduled;
     }
 
     // A GC runs in the following sequence.
@@ skipping 461 matching lines @@
 };
 
 template<> class ThreadStateFor<AnyThread> {
 public:
     static ThreadState* state() { return ThreadState::current(); }
 };
 
 } // namespace blink
 
 #endif // ThreadState_h