Fix disassembler crash when mistaking integer values for objects.

runtime/vm/disassembler_ia32.cc

Index: runtime/vm/disassembler_ia32.cc
===================================================================
--- runtime/vm/disassembler_ia32.cc	(revision 31562)
+++ runtime/vm/disassembler_ia32.cc	(working copy)
@@ -472,8 +472,10 @@
   Print(addr_buffer);
   // Try to print as heap object or stub name
   if (((addr & kSmiTagMask) == kHeapObjectTag) &&
+      reinterpret_cast<RawObject*>(addr)->IsOldObject() &&
       !Isolate::Current()->heap()->CodeContains(addr) &&
-      Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
+      Isolate::Current()->heap()->OldContains(addr - kHeapObjectTag) &&

[Ivan Posva, 2014/01/07 20:54:59]

CanFindOldObject does OldContains implicitly. So we should probably save the
iteration over the pages here.

[srdjan, 2014/01/07 21:02:57]

Removed call to OldContains.

+      Disassembler::CanFindOldObject(addr)) {
     const Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
     if (obj.IsArray()) {
       const Array& arr = Array::Cast(obj);