FX_BOOL considered harmful.

fpdfsdk/src/formfiller/FFL_TextField.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/formfiller/FFL_TextField.h"
 #include "../../include/formfiller/FFL_CBA_Fontmap.h"
 
 /* ------------------------------- CFFL_TextField ------------------------------- */
@@ skipping 111 matching lines @@
                 {
                         pWnd->SetLimitChar(nMaxLen);
                 }
         }
 
         pWnd->SetText(swValue.c_str());
         return pWnd;
 }
 
 
-FX_BOOL CFFL_TextField::OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar, FX_UINT nFlags)
+bool    CFFL_TextField::OnChar(CPDFSDK_Annot* pAnnot, FX_UINT nChar, FX_UINT nFlags)
 {
         switch (nChar)
         {
         case FWL_VKEY_Return:
                 if (!(m_pWidget->GetFieldFlags() & FIELDFLAG_MULTILINE))
                 {
                         CPDFSDK_PageView* pPageView = GetCurPageView();
                         ASSERT(pPageView != NULL);
                         m_bValid = !m_bValid;
                         CPDF_Rect rcAnnot = pAnnot->GetRect();
                         m_pApp->FFI_Invalidate(pAnnot->GetPDFPage(), rcAnnot.left, rcAnnot.top, rcAnnot.right, rcAnnot.bottom);
 
                         if (m_bValid)
                         {
-                                if (CPWL_Wnd* pWnd = GetPDFWindow(pPageView, TRUE))
+                                if (CPWL_Wnd* pWnd = GetPDFWindow(pPageView, true))
                                         pWnd->SetFocus();
                         }
                         else
                         {
                                 if (CommitData(pPageView, nFlags))
                                 {
                                         DestroyPDFWindow(pPageView);
-                                        return TRUE;
+                                        return true;
                                 }
                                 else
                                 {
-                                        return FALSE;
+                                        return false;
                                 }
                         }
                 }
                 break;
         case FWL_VKEY_Escape:
                 {
                         CPDFSDK_PageView* pPageView = GetCurPageView();
                         ASSERT(pPageView != NULL);
-                        EscapeFiller(pPageView,TRUE);
-                        return TRUE;
+                        EscapeFiller(pPageView,true);
+                        return true;
                 }
         }
 
         return CFFL_FormFiller::OnChar(pAnnot, nChar, nFlags);
 }
 
-FX_BOOL CFFL_TextField::IsDataChanged(CPDFSDK_PageView* pPageView)
+bool    CFFL_TextField::IsDataChanged(CPDFSDK_PageView* pPageView)
 {
         ASSERT(m_pWidget != NULL);
 
-        if (CPWL_Edit * pEdit = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+        if (CPWL_Edit * pEdit = (CPWL_Edit*)GetPDFWindow(pPageView, false))
                 return pEdit->GetText() != m_pWidget->GetValue();
 
-        return FALSE;
+        return false;
 }
 
 void CFFL_TextField::SaveData(CPDFSDK_PageView* pPageView)
 {
         ASSERT(m_pWidget != NULL);
 
-        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, false))
         {
                 CFX_WideString sOldValue = m_pWidget->GetValue();
                 CFX_WideString sNewValue = pWnd->GetText();
 
-                m_pWidget->SetValue(sNewValue, FALSE);
-                m_pWidget->ResetFieldAppearance(TRUE);
+                m_pWidget->SetValue(sNewValue, false);
+                m_pWidget->ResetFieldAppearance(true);
                 m_pWidget->UpdateField();
                 SetChangeMark();
         }
 }
 
 void CFFL_TextField::GetActionData(CPDFSDK_PageView* pPageView, CPDF_AAction::AActionType type,
                                                                         PDFSDK_FieldAction& fa)
 {
         switch (type)
         {
         case CPDF_AAction::KeyStroke:
-                if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+                if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, false))
                 {
                         fa.bFieldFull = pWnd->IsTextFull();
 
                         fa.sValue = pWnd->GetText();
 
                         if (fa.bFieldFull)
                         {
                                 fa.sChange = L"";
                                 fa.sChangeEx = L"";
                         }
                 }
                 break;
         case CPDF_AAction::Validate:
-                if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+                if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, false))
                 {
                         fa.sValue = pWnd->GetText();
                 }
                 break;
         case CPDF_AAction::LoseFocus:
         case CPDF_AAction::GetFocus:
                 ASSERT(m_pWidget != NULL);
                 fa.sValue = m_pWidget->GetValue();
                 break;
         default:
                 break;
         }
 }
 
 void CFFL_TextField::SetActionData(CPDFSDK_PageView* pPageView, CPDF_AAction::AActionType type,
                                                                         const PDFSDK_FieldAction& fa)
 {
         switch (type)
         {
         case CPDF_AAction::KeyStroke:
-                if (CPWL_Edit * pEdit = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+                if (CPWL_Edit * pEdit = (CPWL_Edit*)GetPDFWindow(pPageView, false))
                 {
                         pEdit->SetFocus();
                         pEdit->SetSel(fa.nSelStart, fa.nSelEnd);
                         pEdit->ReplaceSel(fa.sChange.c_str());
                 }
                 break;
         default:
                 break;
         }
 }
 
 
-FX_BOOL CFFL_TextField::IsActionDataChanged(CPDF_AAction::AActionType type, const PDFSDK_FieldAction& faOld,
+bool    CFFL_TextField::IsActionDataChanged(CPDF_AAction::AActionType type, const PDFSDK_FieldAction& faOld,
                                                                         const PDFSDK_FieldAction& faNew)
 {
         switch (type)
         {
         case CPDF_AAction::KeyStroke:
                 return (!faOld.bFieldFull && faOld.nSelEnd != faNew.nSelEnd) || faOld.nSelStart != faNew.nSelStart ||
                         faOld.sChange != faNew.sChange;
         default:
                 break;
         }
 
-        return FALSE;
+        return false;
 }
 
 void CFFL_TextField::SaveState(CPDFSDK_PageView* pPageView)
 {
         ASSERT(pPageView != NULL);
 
-        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, FALSE))
+        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, false))
         {
                 pWnd->GetSel(m_State.nStart, m_State.nEnd);
                 m_State.sValue = pWnd->GetText();
         }
 }
 
 void CFFL_TextField::RestoreState(CPDFSDK_PageView* pPageView)
 {
         ASSERT(pPageView != NULL);
 
-        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, TRUE))
+        if (CPWL_Edit* pWnd = (CPWL_Edit*)GetPDFWindow(pPageView, true))
         {
                 pWnd->SetText(m_State.sValue.c_str());
                 pWnd->SetSel(m_State.nStart, m_State.nEnd);
         }
 }
 
-CPWL_Wnd* CFFL_TextField::ResetPDFWindow(CPDFSDK_PageView* pPageView, FX_BOOL bRestoreValue)
+CPWL_Wnd* CFFL_TextField::ResetPDFWindow(CPDFSDK_PageView* pPageView, bool bRestoreValue)
 {
         if (bRestoreValue)
                 SaveState(pPageView);
 
         DestroyPDFWindow(pPageView);
 
         CPWL_Wnd* pRet = NULL;
 
         if (bRestoreValue)
         {
                 RestoreState(pPageView);
-                pRet = GetPDFWindow(pPageView, FALSE);
+                pRet = GetPDFWindow(pPageView, false);
         }
         else
-                pRet = GetPDFWindow(pPageView, TRUE);
+                pRet = GetPDFWindow(pPageView, true);
 
         m_pWidget->UpdateField();
 
         return pRet;
 }
 
 void CFFL_TextField::OnSetFocus(CPWL_Wnd* pWnd)
 {
         ASSERT(m_pApp != NULL);
 
         ASSERT(pWnd != NULL);
 
         if (pWnd->GetClassName() == PWL_CLASSNAME_EDIT)
         {
                 CPWL_Edit* pEdit = (CPWL_Edit*)pWnd;
                 pEdit->SetCharSet(134);
                 pEdit->SetCodePage(936);
 
                 pEdit->SetReadyToInput();
                 CFX_WideString wsText = pEdit->GetText();
                 int nCharacters = wsText.GetLength();
                 CFX_ByteString bsUTFText = wsText.UTF16LE_Encode();
                 unsigned short* pBuffer = (unsigned short*)bsUTFText.c_str();
-                m_pApp->FFI_OnSetFieldInputFocus(m_pWidget->GetFormField(), pBuffer, nCharacters, TRUE);
+                m_pApp->FFI_OnSetFieldInputFocus(m_pWidget->GetFormField(), pBuffer, nCharacters, true);
 
                 pEdit->SetEditNotify(this);
                 //pUndo->BeginEdit(pDocument);
         }
 }
 
 void CFFL_TextField::OnKillFocus(CPWL_Wnd* pWnd)
 {
 
 }
 
-FX_BOOL CFFL_TextField::CanCopy(CPDFSDK_Document* pDocument)
+bool    CFFL_TextField::CanCopy(CPDFSDK_Document* pDocument)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL CFFL_TextField::CanCut(CPDFSDK_Document* pDocument)
+bool CFFL_TextField::CanCut(CPDFSDK_Document* pDocument)
 {
-        return FALSE;
+        return false;
 }
 
-FX_BOOL CFFL_TextField::CanPaste(CPDFSDK_Document* pDocument)
+bool    CFFL_TextField::CanPaste(CPDFSDK_Document* pDocument)
 {
-        return FALSE;
+        return false;
 }
 
 void CFFL_TextField::OnAddUndo(CPWL_Edit* pEdit)
 {
 }