pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 1252533003: dart2js: fix named arguments with Function.apply in the startup emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 1252533003: dart2js: fix named arguments with Function.apply in the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/model.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 7e981fc8796a42d87a92ece02349e8c2fbb3341b..1b9b6effb4c02f35dddcb2878afc60c477c5e3fe 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -559,7 +559,7 @@ class ProgramBuilder {

bool canTearOff = false;

js.Name tearOffName;

- bool isClosure = false;

+ bool isClosureCallMethod = false;

bool isNotApplyTarget = !element.isFunction || element.isAccessor;

bool canBeReflected = _methodCanBeReflected(element);

@@ -574,7 +574,7 @@ class ProgramBuilder {

} else {

if (element.enclosingClass.isClosure) {

canTearOff = false;

- isClosure = true;

+ isClosureCallMethod = true;

} else {

// Careful with operators.

canTearOff = universe.hasInvokedGetter(element, _compiler.world) ||

@@ -628,7 +628,7 @@ class ProgramBuilder {

return new InstanceMethod(element, name, code,

_generateParameterStubs(element, canTearOff), callName,

needsTearOff: canTearOff, tearOffName: tearOffName,

- isClosure: isClosure, aliasName: aliasName,

+ isClosureCallMethod: isClosureCallMethod, aliasName: aliasName,

canBeApplied: canBeApplied, canBeReflected: canBeReflected,

requiredParameterCount: requiredParameterCount,

optionalParameterDefaultValues: optionalParameterDefaultValues,