pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart - Issue 1252533003: dart2js: fix named arguments with Function.apply in the startup emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

Issue 1252533003: dart2js: fix named arguments with Function.apply in the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

index b0a94ceccf060b3bb3482874d57117bda168de0f..ebd7d1a1d2ad9df200e6962dcb69a28746240474 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

@@ -20,7 +20,7 @@ class ContainerBuilder extends CodeEmitterHelper {

bool canBeReflected = method.canBeReflected;

bool canTearOff = method.needsTearOff;

jsAst.Name tearOffName = method.tearOffName;

- bool isClosure = method is InstanceMethod && method.isClosure;

+ bool isClosure = method is InstanceMethod && method.isClosureCallMethod;

jsAst.Name superAlias = method is InstanceMethod ? method.aliasName : null;

bool hasSuperAlias = superAlias != null;

jsAst.Expression memberTypeExpression = method.functionType;

« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/model.dart » ('j') | no next file with comments »