Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: pkg/analyzer/lib/src/services/formatter_impl.dart

Issue 125253005: Formatter support for metadata. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer/lib/src/services/formatter_impl.dart (revision 31491)
+++ pkg/analyzer/lib/src/services/formatter_impl.dart (working copy)
@@ -496,6 +496,7 @@
visitClassDeclaration(ClassDeclaration node) {
preserveLeadingNewlines();
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.abstractKeyword);
token(node.classKeyword);
space();
@@ -517,11 +518,12 @@
visitClassTypeAlias(ClassTypeAlias node) {
preserveLeadingNewlines();
+ visitNodes(node.metadata, followedBy: newlines);
//TODO(pquitslund): the following _should_ work (dartbug.com/15912)
//modifier(node.abstractKeyword);
// ... in the meantime we use this workaround
var prev = node.keyword.previous;
- if (prev.keyword == Keyword.ABSTRACT) {
+ if (prev is KeywordToken && prev.keyword == Keyword.ABSTRACT) {
token(prev);
space();
}
@@ -582,6 +584,7 @@
}
visitConstructorDeclaration(ConstructorDeclaration node) {
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.externalKeyword);
modifier(node.constKeyword);
modifier(node.factoryKeyword);
@@ -702,6 +705,7 @@
}
visitExportDirective(ExportDirective node) {
+ visitNodes(node.metadata, followedBy: newlines);
token(node.keyword);
space();
visit(node.uri);
@@ -730,6 +734,7 @@
}
visitFieldDeclaration(FieldDeclaration node) {
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.staticKeyword);
visit(node.fields);
token(node.semicolon);
@@ -815,6 +820,7 @@
visitFunctionDeclaration(FunctionDeclaration node) {
preserveLeadingNewlines();
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.externalKeyword);
//TODO(pquitslund): remove this workaround once setter functions
//have their return types properly set (dartbug.com/15914)
@@ -895,6 +901,7 @@
}
visitImportDirective(ImportDirective node) {
+ visitNodes(node.metadata, followedBy: newlines);
token(node.keyword);
space();
visit(node.uri);
@@ -963,6 +970,7 @@
}
visitLibraryDirective(LibraryDirective node) {
+ visitNodes(node.metadata, followedBy: newlines);
token(node.keyword);
space();
visit(node.name);
@@ -1005,6 +1013,7 @@
}
visitMethodDeclaration(MethodDeclaration node) {
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.externalKeyword);
modifier(node.modifierKeyword);
visitNode(node.returnType, followedBy: space);
@@ -1131,6 +1140,7 @@
}
visitSimpleFormalParameter(SimpleFormalParameter node) {
+ visitNodes(node.metadata, followedBy: space);
modifier(node.keyword);
visitNode(node.type, followedBy: space);
visit(node.identifier);
@@ -1234,6 +1244,7 @@
}
visitTypeParameter(TypeParameter node) {
+ visitNodes(node.metadata, followedBy: space);
visit(node.name);
token(node.keyword /* extends */, precededBy: space, followedBy: space);
visit(node.bound);
@@ -1264,6 +1275,7 @@
}
visitVariableDeclarationList(VariableDeclarationList node) {
+ visitNodes(node.metadata, followedBy: newlines);
modifier(node.keyword);
visitNode(node.type, followedBy: space);
visitCommaSeparatedNodes(node.variables);
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698