Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 125253002: create gm/rebaseline_server/test_all.py (Closed)

Created:
6 years, 11 months ago by epoger
Modified:
6 years, 11 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

create gm/rebaseline_server/test_all.py Uses proper Python unittest framework to launch all unittests within the directory. NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=12915

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -49 lines) Patch
M gm/rebaseline_server/imagediffdb_test.py View 1 1 chunk +62 lines, -45 lines 0 comments Download
M gm/rebaseline_server/results_test.py View 2 chunks +4 lines, -4 lines 0 comments Download
A gm/rebaseline_server/test_all.py View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review at patchset 1. https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py File gm/rebaseline_server/imagediffdb_test.py (right): https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py#newcode2 gm/rebaseline_server/imagediffdb_test.py:2: Here's what the ...
6 years, 11 months ago (2014-01-06 18:21:06 UTC) #1
rmistry
LGTM https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py File gm/rebaseline_server/imagediffdb_test.py (right): https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py#newcode56 gm/rebaseline_server/imagediffdb_test.py:56: IMAGE_URL_BASE + 'gradients_degenerate_2pt/10552995703607727960.png', Nit: line > 80, use ...
6 years, 11 months ago (2014-01-06 18:23:40 UTC) #2
epoger
https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py File gm/rebaseline_server/imagediffdb_test.py (right): https://codereview.chromium.org/125253002/diff/1/gm/rebaseline_server/imagediffdb_test.py#newcode56 gm/rebaseline_server/imagediffdb_test.py:56: IMAGE_URL_BASE + 'gradients_degenerate_2pt/10552995703607727960.png', On 2014/01/06 18:23:40, rmistry wrote: > ...
6 years, 11 months ago (2014-01-06 18:33:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/125253002/50001
6 years, 11 months ago (2014-01-06 18:33:13 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 18:33:24 UTC) #5
Message was sent while issue was closed. 
Change committed as 12915

Powered by Google App Engine
This is Rietveld 408576698