Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1252513004: Revert of Reduce duplicate code in full-codegen across platforms. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reduce duplicate code in full-codegen across platforms. (patchset #1 id:1 of https://codereview.chromium.org/1255613002/) Reason for revert: breaks mips Original issue's description: > Reduce duplicate code in full-codegen across platforms. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/937d4efbf9c399339fdc8e041bec8e80baa7b58f > Cr-Commit-Position: refs/heads/master@{#29798} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8de3518e3a51d650683641b8968c6d3e1252391a Cr-Commit-Position: refs/heads/master@{#29802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+984 lines, -124 lines) Patch
M src/arm/full-codegen-arm.cc View 8 chunks +123 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 8 chunks +123 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +0 lines, -124 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 8 chunks +124 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 8 chunks +124 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 8 chunks +124 lines, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 8 chunks +121 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 8 chunks +122 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 8 chunks +123 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Reduce duplicate code in full-codegen across platforms.
5 years, 5 months ago (2015-07-23 09:49:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252513004/1
5 years, 5 months ago (2015-07-23 09:49:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 09:50:31 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 09:50:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8de3518e3a51d650683641b8968c6d3e1252391a
Cr-Commit-Position: refs/heads/master@{#29802}

Powered by Google App Engine
This is Rietveld 408576698