Added flag simplified-fullscreen-ui.

Added flag simplified-fullscreen-ui.

This flag will be used for experimenting with a streamlined fullscreen
and mouse pointer lock UX. In this patch, the flag removes the prompt to
allow sites to go fullscreen or take pointer lock (permission is
automatically granted).

BUG=352425
Committed: https://crrev.com/8ddab2501634f11a0c3e5bcafcaac3449716356e
Cr-Commit-Position: refs/heads/master@{#341281}

[Matt Giuca, 2015-07-29 03:48:26]

mgiuca@chromium.org changed reviewers:
+ asvitkine@chromium.org, scheib@chromium.org

[Matt Giuca, 2015-07-29 03:48:27]

asvitkine@chromium.org: Please review changes in histograms.xml.

scheib@chromium.org: Please review whole CL.

[Alexei Svitkine (slow), 2015-07-29 15:08:30]

lgtm

[scheib, 2015-07-30 18:32:27]

LGTM, but let's think about this design question and add a TODO with issue
number if we believe it should be addressed.

https://codereview.chromium.org/1252503007/diff/20001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (right):

https://codereview.chromium.org/1252503007/diff/20001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:512: // If
simplified UI is enabled, never ask the user, just auto-allow.
I must be rusty on this, but, woah, why doesn't fullscreen have BLOCK permission
in content settings? For now it seems that it doesn't, so this would be OK. But
if Block were possible then this could would need to check first for BLOCK.

So.... I suppose no action to take here unless you also find it unnerving that
content settings doesn't allow this to be blocked, in which case we should bring
it up in design discussion.

[Matt Giuca, 2015-07-31 03:12:50]

https://codereview.chromium.org/1252503007/diff/20001/chrome/browser/ui/exclu...
File chrome/browser/ui/exclusive_access/fullscreen_controller.cc (right):

https://codereview.chromium.org/1252503007/diff/20001/chrome/browser/ui/exclu...
chrome/browser/ui/exclusive_access/fullscreen_controller.cc:512: // If
simplified UI is enabled, never ask the user, just auto-allow.
Interesting. Well I just filed http://crbug.com/515747 for discussion and
linking.

I think with the current design, we should allow the user to block this. But if
we are going forward to auto-allowing, then we probably don't want to allow
that. Discuss on the bug.

[Matt Giuca, 2015-07-31 03:12:52]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-07-31 03:12:53]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1252503007/#ps40001
(title: "Added link to discussion bug 515747.")

[commit-bot: I haz the power, 2015-07-31 03:13:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252503007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252503007/40001

[commit-bot: I haz the power, 2015-07-31 04:38:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-31 04:39:27]

Patchset 3 (id:??) landed as
https://crrev.com/8ddab2501634f11a0c3e5bcafcaac3449716356e
Cr-Commit-Position: refs/heads/master@{#341281}