dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart - Issue 12525007: Record dependency information to implement first version of dependency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 12525007: Record dependency information to implement first version of dependency (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

index e9bae5e64fa4ae87dcc588fe4a6a74f034c58cda..edacc149d0392d4fc01efba696a9c28202406122 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

@@ -283,7 +283,7 @@ class Dart2JsCompilation implements Compilation {

opts.add('--analyze-all');

_compiler = new Compiler(provider.readStringFromUri,

null,

- silentDiagnosticHandler,

+ (x1, x2, x3, x4, x5) => null,

ahe 2013/03/06 16:01:42 Should disappear when I merge with top of tree.

libraryUri, packageUri, opts);

var librariesUri = <Uri>[];

for (Path library in libraries) {