Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5203)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12525007: Record dependency information to implement first version of dependency (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index f2fe22c45fd848d7a1c8284cdcb84a38d8fa7d94..d8cc3e10696f1168dec538fa26120c5f5495360b 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1526,7 +1526,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
methodName = 'split';
// Split returns a List, so we make sure the backend knows the
// list class is instantiated.
- world.registerInstantiatedClass(compiler.listClass);
+ world.registerInstantiatedClass(
+ compiler.listClass, compiler.globalDependencies);
} else if (target == backend.jsStringConcat) {
push(new js.Binary('+', object, arguments[0]), node);
return;
@@ -1647,7 +1648,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void registerGetter(HInvokeDynamic node) {
Selector selector = getOptimizedSelectorFor(node, node.selector);
world.registerDynamicGetter(selector.name, selector);
- world.registerInstantiatedClass(compiler.functionClass);
+ world.registerInstantiatedClass(
+ compiler.functionClass, compiler.globalDependencies);
registerInvoke(node, selector);
}
@@ -1775,7 +1777,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
assert(type == HType.UNKNOWN);
return;
}
- world.registerInstantiatedClass(dartType.element);
+ world.registerInstantiatedClass(
+ dartType.element, compiler.globalDependencies);
}
visitForeign(HForeign node) {
@@ -1839,7 +1842,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
ConstantHandler handler = compiler.constantHandler;
handler.registerCompileTimeConstant(node.constant);
}
- world.registerInstantiatedClass(type.element);
+ world.registerInstantiatedClass(
+ type.element, compiler.globalDependencies);
}
visitNot(HNot node) {
@@ -2048,7 +2052,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
if (instr is !HInvokeStatic) {
backend.registerNonCallStaticUse(node);
if (node.element.isFunction()) {
- world.registerInstantiatedClass(compiler.functionClass);
+ world.registerInstantiatedClass(
+ compiler.functionClass, compiler.globalDependencies);
}
} else if (instr.target != node) {
backend.registerNonCallStaticUse(node);
@@ -2059,7 +2064,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
ClassElement cls = element.getEnclosingClass();
if (element.isGenerativeConstructor()
|| (element.isFactoryConstructor() && cls == compiler.listClass)) {
- world.registerInstantiatedClass(cls);
+ world.registerInstantiatedClass(cls, compiler.globalDependencies);
}
push(new js.VariableUse(backend.namer.isolateAccess(node.element)));
}
@@ -2115,7 +2120,8 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
void visitLiteralList(HLiteralList node) {
- world.registerInstantiatedClass(compiler.listClass);
+ world.registerInstantiatedClass(
+ compiler.listClass, compiler.globalDependencies);
generateArrayLiteral(node);
}
@@ -2249,7 +2255,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void checkType(HInstruction input, DartType type, {bool negative: false}) {
assert(invariant(input, !type.isMalformed,
message: 'Attempt to check malformed type $type'));
- world.registerIsCheck(type);
+ world.registerIsCheck(type, compiler.globalDependencies);
Element element = type.element;
use(input);
js.PropertyAccess field =
@@ -2311,7 +2317,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitIs(HIs node) {
DartType type = node.typeExpression;
- world.registerIsCheck(type);
+ world.registerIsCheck(type, compiler.globalDependencies);
Element element = type.element;
if (identical(element.kind, ElementKind.TYPE_VARIABLE)) {
compiler.unimplemented("visitIs for type variables",
@@ -2384,7 +2390,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
if (node.isChecked) {
DartType type = node.instructionType.computeType(compiler);
Element element = type.element;
- world.registerIsCheck(type);
+ world.registerIsCheck(type, compiler.globalDependencies);
if (node.isArgumentTypeCheck) {
if (element == backend.jsIntClass) {

Powered by Google App Engine
This is Rietveld 408576698