Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 12524008: Android: factor out use of SDK jar. (Closed)

Created:
7 years, 9 months ago by Torne
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Android: factor out use of SDK jar. Specify the path to the Android SDK main jarfile in a single location so that it can be overridden by the WebView build. BUG= TBR=fischman@chromium.org,brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188737

Patch Set 1 #

Patch Set 2 : Remove input_jar_file altogether. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M android_webview/native/webview_native.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/common.gypi View 2 chunks +6 lines, -3 lines 0 comments Download
M build/jar_file_jni_generator.gypi View 1 4 chunks +3 lines, -4 lines 0 comments Download
M build/java.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M content/content.gyp View 1 3 chunks +0 lines, -3 lines 0 comments Download
M media/media.gyp View 1 3 chunks +0 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
Hi Marcus, It turns out that there *are* a few uses of the jar jni ...
7 years, 9 months ago (2013-03-18 14:18:35 UTC) #1
Torne
OK, turns out I was mistaken and the other uses of input_jar_file are actually referring ...
7 years, 9 months ago (2013-03-18 14:32:50 UTC) #2
bulach
lgtm, thanks!
7 years, 9 months ago (2013-03-18 14:38:41 UTC) #3
Torne
We need to land this as a prerequisite for fixing the downstream android webview build, ...
7 years, 9 months ago (2013-03-18 15:04:21 UTC) #4
Torne
Committed patchset #2 manually as r188737 (presubmit successful).
7 years, 9 months ago (2013-03-18 15:05:17 UTC) #5
Ami GONE FROM CHROMIUM
7 years, 9 months ago (2013-03-18 15:48:44 UTC) #6
Message was sent while issue was closed.
post-commit LGTM

Powered by Google App Engine
This is Rietveld 408576698