Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1252393003: Reland of ll third_party/custom_tabs_client (Closed)

Created:
5 years, 4 months ago by timvolodine
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ll third_party/custom_tabs_client (patchset #1 id:1 of https://codereview.chromium.org/1263983002/) Reason for revert: hmm sorry this doesn't appear to have been the reason for issues on the bot. putting the roll back in. Original issue's description: > Revert of Roll third_party/custom_tabs_client (patchset #1 id:1 of https://codereview.chromium.org/1254383014/) > > Reason for revert: > speculative revert, prevents clank roll downstream, see crbug.com/515457 > > Original issue's description: > > Roll third_party/custom_tabs_client > > > > Roll from 6bae8bf337d5c51184c0c01f5baca3e0858 to > > 19d5cb35bece11876e8f34c17c6fdfd9bad. > > > > BUG=510083 > > > > Committed: https://crrev.com/dc731ce3111a8d4f316e478601707cc33e70e542 > > Cr-Commit-Position: refs/heads/master@{#341048} > > TBR=yusufo@chromium.org,ianwen@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=510083 > > Committed: https://crrev.com/66d3e303ded89c565e8fb33d8000044cdcf2b8c1 > Cr-Commit-Position: refs/heads/master@{#341100} TBR=yusufo@chromium.org,ianwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510083 Committed: https://crrev.com/e6689c2a7fec438c94b89155568b82bc9a2f6ad9 Cr-Commit-Position: refs/heads/master@{#341104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
timvolodine
Created Reland of ll third_party/custom_tabs_client
5 years, 4 months ago (2015-07-30 12:48:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252393003/1
5 years, 4 months ago (2015-07-30 12:48:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 12:49:17 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:49:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6689c2a7fec438c94b89155568b82bc9a2f6ad9
Cr-Commit-Position: refs/heads/master@{#341104}

Powered by Google App Engine
This is Rietveld 408576698