Make VS2015 component builds work on swarming.

Make VS2015 component builds work on swarming.

BUG=440500
Committed: https://crrev.com/568e81bce0dbf53936edfb4d54a5714749a2e619
Cr-Commit-Position: refs/heads/master@{#343482}

[Sébastien Marchand, 2015-08-03 21:32:19]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-03 21:32:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252353005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252353005/1

[Sébastien Marchand, 2015-08-03 21:33:12]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org, thakis@chromium.org

[Sébastien Marchand, 2015-08-03 21:33:12]

PTAL

[commit-bot: I haz the power, 2015-08-03 21:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 21:36:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2015-08-03 21:56:48]

Lgtm once the bots like it. Not sure if gn needs anything like this.

[Dirk Pranke, 2015-08-03 22:00:27]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-08-03 22:00:27]

GN will probably need something similar at some point. So far we're only running
static builds through swarming.

[Sébastien Marchand, 2015-08-04 13:46:38]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-04 13:46:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252353005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252353005/20001

[commit-bot: I haz the power, 2015-08-04 14:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 14:04:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sébastien Marchand, 2015-08-04 17:46:01]

It looks like the isolate file format doesn't allow for nested conditions and it
doesn't do a left to right check of its conditions (i.e. "OS=="win" and
msvs_version==2013" will fail if msvs_version even if OS!="win")...

So I should either fix isolate.py, or provide a default value for msvs_version
on all platforms... I don't really like this approach but it's probably the best
short term fix...

[brucedawson, 2015-08-04 20:58:49]

Maybe rename it from msvs_version to compiler_version, which can be msvs_2013,
msvs_2015, or gcc_47, etc.

[Sébastien Marchand, 2015-08-04 21:16:36]

yeah, but this might create some confusion too.. We'll introduce a global
variable that will only be used on Windows, so 2 things can happen:
- We'll set it to 0 on the platforms where it doesn't get used, and some people
will wonder why there's a 'compiler_version=0' flag on the isolate.py command
line.
- We'll set it to the appropriate version on each platforms, and then we'll
switch to gcc 4.8 and nobody will ever update this value.

So there's no ideal solution here, we can maybe just wait for maruel@ to be back
from vacation to see if isolate file format limitations are here on purpose or
not, if not then the best way to fix this will probably be to add support for
nested conditions or to implement left to right parsing of the conditions...

[M-A Ruel, 2015-08-10 15:03:22]

On 2015/08/04 21:16:36, Sébastien Marchand wrote:
> yeah, but this might create some confusion too.. We'll introduce a global
> variable that will only be used on Windows, so 2 things can happen:
> - We'll set it to 0 on the platforms where it doesn't get used, and some
people
> will wonder why there's a 'compiler_version=0' flag on the isolate.py command
> line.
> - We'll set it to the appropriate version on each platforms, and then we'll
> switch to gcc 4.8 and nobody will ever update this value.
> 
> So there's no ideal solution here, we can maybe just wait for maruel@ to be
back
> from vacation to see if isolate file format limitations are here on purpose or
> not, if not then the best way to fix this will probably be to add support for
> nested conditions or to implement left to right parsing of the conditions...

Can't we just map everything? It's not that much a big deal and simplifies
everything. We can then revisit once fully switched to GN.

[Sébastien Marchand, 2015-08-11 18:41:17]

Nop we can't, the *140.dll files are present only if VS2015 has been downloaded
(i.e. the dev has set GYP_MSVS_VERSION=2015).

[Sébastien Marchand, 2015-08-11 18:56:57]

Patchset #3 (id:40001) has been deleted

[Sébastien Marchand, 2015-08-11 19:42:21]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 19:43:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252353005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252353005/60001

[Sébastien Marchand, 2015-08-11 21:10:44]

sebmarchand@chromium.org changed reviewers:
+ maruel@chromium.org

[Sébastien Marchand, 2015-08-11 21:10:44]

+maruel for the .isolate changes.

[M-A Ruel, 2015-08-11 21:12:19]

lgtm, thanks

[Sébastien Marchand, 2015-08-11 21:13:13]

The CQ bit was unchecked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-08-11 21:13:23]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-08-11 21:13:23]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1252353005/#ps60001
(title: "Move the msvs dependencies into their own isolate file.")

[commit-bot: I haz the power, 2015-08-11 21:14:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252353005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252353005/60001

[commit-bot: I haz the power, 2015-08-11 22:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 22:56:43]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Sébastien Marchand, 2015-08-14 18:57:19]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2015-08-14 18:57:19]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1252353005/#ps80001
(title: "Update the Androit isolator script.")

[commit-bot: I haz the power, 2015-08-14 18:57:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252353005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252353005/80001

[commit-bot: I haz the power, 2015-08-14 20:38:27]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-08-14 20:39:02]

Patchset 4 (id:??) landed as
https://crrev.com/568e81bce0dbf53936edfb4d54a5714749a2e619
Cr-Commit-Position: refs/heads/master@{#343482}