Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1252333002: Don't try to get the mark bits of the one ptr filler object (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't try to get the mark bits of the one ptr filler object BUG=chromium:??? LOG=n R=mlippautz@chromium.org,hpayer@chromium.org Committed: https://crrev.com/3eb91e8aec8e628adc1046fca16c5dfd1d129118 Cr-Commit-Position: refs/heads/master@{#29850}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/heap/heap.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-24 12:15:04 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/1252333002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1252333002/diff/1/src/heap/heap.cc#newcode6214 src/heap/heap.cc:6214: if (object->map() == heap_->one_pointer_filler_map()) return true; Object::IsFiller() is the ...
5 years, 5 months ago (2015-07-24 13:25:03 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-24 13:27:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252333002/20001
5 years, 5 months ago (2015-07-24 14:13:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 14:36:40 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 14:36:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3eb91e8aec8e628adc1046fca16c5dfd1d129118
Cr-Commit-Position: refs/heads/master@{#29850}

Powered by Google App Engine
This is Rietveld 408576698