[iOS] Upstream //ios/chrome/browser/signin/signin_util

[iOS] Upstream //ios/chrome/browser/signin/signin_util

Committed: https://crrev.com/fbb7c3950be43938e2051ceac308d668ad364053
Cr-Commit-Position: refs/heads/master@{#341712}

[droger, 2015-08-03 16:37:22]

droger@chromium.org changed reviewers:
+ bzanotti@chromium.org

[bzanotti, 2015-08-03 18:06:00]

lgtm

https://codereview.chromium.org/1252323006/diff/1/ios/chrome/browser/signin/s...
File ios/chrome/browser/signin/signin_util.h (right):

https://codereview.chromium.org/1252323006/diff/1/ios/chrome/browser/signin/s...
ios/chrome/browser/signin/signin_util.h:18: // Returns the canonicalized and
sanitized user email for the give identity.
s/give/given/

[droger, 2015-08-04 08:35:29]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[droger, 2015-08-04 08:35:30]

+sdefresne for committer review.

[sdefresne, 2015-08-04 08:46:17]

lgtm

https://codereview.chromium.org/1252323006/diff/20001/ios/chrome/browser/sign...
File ios/chrome/browser/signin/signin_util.mm (right):

https://codereview.chromium.org/1252323006/diff/20001/ios/chrome/browser/sign...
ios/chrome/browser/signin/signin_util.mm:14: for
(std::set<std::string>::iterator it = scopes.begin(); it != scopes.end();
nit: use c++11 for loop

for (const auto& scope : scopes) {
  [scoped_array addObject:base::SysUTF8ToNSString(scope)];
}

https://codereview.chromium.org/1252323006/diff/20001/ios/chrome/browser/sign...
ios/chrome/browser/signin/signin_util.mm:24: return "";
return std::string();

[droger, 2015-08-04 09:26:19]

All done.

[droger, 2015-08-04 09:26:22]

The CQ bit was checked by droger@chromium.org

[droger, 2015-08-04 09:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
bzanotti@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1252323006/#ps40001
(title: "Review commenst")

[commit-bot: I haz the power, 2015-08-04 09:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252323006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252323006/40001

[commit-bot: I haz the power, 2015-08-04 09:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 09:40:33]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[droger, 2015-08-04 11:38:30]

Added SigninErrorProvider which was needed too. Please take a look.

[sdefresne, 2015-08-04 11:42:39]

lgtm

[droger, 2015-08-04 11:47:23]

The CQ bit was checked by droger@chromium.org

[droger, 2015-08-04 11:47:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
bzanotti@chromium.org
Link to the patchset: https://codereview.chromium.org/1252323006/#ps60001
(title: "Add SigninErrorProvider")

[commit-bot: I haz the power, 2015-08-04 11:47:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252323006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252323006/60001

[commit-bot: I haz the power, 2015-08-04 12:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 12:03:52]

Failed to commit the patch.

[commit-bot: I haz the power, 2015-08-04 12:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[droger, 2015-08-04 12:23:45]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-08-04 12:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252323006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252323006/60001

[commit-bot: I haz the power, 2015-08-04 12:29:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-04 12:30:29]

Patchset 4 (id:??) landed as
https://crrev.com/fbb7c3950be43938e2051ceac308d668ad364053
Cr-Commit-Position: refs/heads/master@{#341712}