Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1252323002: Debugger: always include deoptimization support for debug code. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: always include deoptimization support for debug code. R=mstarzinger@chromium.org BUG=chromium:513496 LOG=N Committed: https://crrev.com/cd9ae446ea7bc64bece7bfc7137cb0026ffb037c Cr-Commit-Position: refs/heads/master@{#29846}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M src/compiler.h View 1 3 chunks +5 lines, -8 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 5 months ago (2015-07-24 11:21:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252323002/1
5 years, 5 months ago (2015-07-24 11:48:22 UTC) #3
Michael Starzinger
LGTM with a nit. https://codereview.chromium.org/1252323002/diff/1/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/1252323002/diff/1/src/compiler.h#newcode428 src/compiler.h:428: // NONOPT is generated by ...
5 years, 5 months ago (2015-07-24 12:02:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-24 12:14:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252323002/20001
5 years, 5 months ago (2015-07-24 13:18:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 13:43:45 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 13:43:56 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cd9ae446ea7bc64bece7bfc7137cb0026ffb037c
Cr-Commit-Position: refs/heads/master@{#29846}

Powered by Google App Engine
This is Rietveld 408576698