Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1252313005: Add verification to downloaded files (Closed)

Created:
5 years, 4 months ago by hinoka
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add verification to downloaded files This does one last check to see if the file downloaded by download_from_google_storage.py actually matches its sha1 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296155

Patch Set 1 #

Total comments: 2

Patch Set 2 : continue #

Patch Set 3 : lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M download_from_google_storage.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/download_from_google_storage_unittests.py View 1 2 4 chunks +36 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ryan Tseng
I'm kind of embarrassed this wasn't in there before. Ptal New test passes, some old ...
5 years, 4 months ago (2015-07-29 20:34:30 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1252313005/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/1252313005/diff/1/download_from_google_storage.py#newcode229 download_from_google_storage.py:229: ret_codes.put((code, err)) is it ok that there's no "continue" ...
5 years, 4 months ago (2015-07-29 20:43:49 UTC) #3
Ryan Tseng
Also open question: Should the file be delete if its known to be corrupted. Pros: ...
5 years, 4 months ago (2015-07-29 20:51:24 UTC) #4
Vadim Sh.
lgtm On 2015/07/29 20:51:24, Ryan Tseng wrote: > Also open question: Should the file be ...
5 years, 4 months ago (2015-07-29 20:54:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252313005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252313005/20001
5 years, 4 months ago (2015-07-29 20:56:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/133)
5 years, 4 months ago (2015-07-29 21:01:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252313005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252313005/40001
5 years, 4 months ago (2015-07-29 21:09:38 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 21:11:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296155

Powered by Google App Engine
This is Rietveld 408576698