Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3663)

Unified Diff: cc/trees/property_tree.cc

Issue 1252313004: Add ClipNode when Render Surface Inherits Clip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Layout tests pass , unit test added , comments on patch 11 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/property_tree.cc
diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc
index 05fa3947f0ca18fa42e866a50288836f0a668819..0b60d2792678f0cfaf2a9e316c80afc248122f5a 100644
--- a/cc/trees/property_tree.cc
+++ b/cc/trees/property_tree.cc
@@ -94,8 +94,10 @@ void TransformNodeData::update_post_local_transform(
transform_origin.z());
}
-ClipNodeData::ClipNodeData() : transform_id(-1), target_id(-1) {
-}
+ClipNodeData::ClipNodeData()
+ : transform_id(-1),
+ target_id(-1),
+ inherit_parent_target_space_clip(false) {}
OpacityNodeData::OpacityNodeData() : opacity(1.f), screen_space_opacity(1.f) {
}
@@ -147,6 +149,10 @@ bool TransformTree::ComputeTransformWithSourceSublayerScale(
if (!source_node->data.needs_sublayer_scale)
return success;
+ if (source_node->data.sublayer_scale.x() == 0 ||
+ source_node->data.sublayer_scale.y() == 0)
+ return false;
+
transform->Scale(1.f / source_node->data.sublayer_scale.x(),
1.f / source_node->data.sublayer_scale.y());
return success;

Powered by Google App Engine
This is Rietveld 408576698