Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/compiler/js-generic-lowering.cc

Issue 1252303002: VectorICs: VisitClassLiteral needs adjustment for IC slot usage. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: The wrong IC was chosen without vector stores on. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/code-stubs.h" 6 #include "src/code-stubs.h"
7 #include "src/compiler/common-operator.h" 7 #include "src/compiler/common-operator.h"
8 #include "src/compiler/js-generic-lowering.h" 8 #include "src/compiler/js-generic-lowering.h"
9 #include "src/compiler/js-graph.h" 9 #include "src/compiler/js-graph.h"
10 #include "src/compiler/machine-operator.h" 10 #include "src/compiler/machine-operator.h"
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index())); 352 node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
353 ReplaceWithStubCall(node, callable, flags); 353 ReplaceWithStubCall(node, callable, flags);
354 } 354 }
355 } 355 }
356 356
357 357
358 void JSGenericLowering::LowerJSStoreProperty(Node* node) { 358 void JSGenericLowering::LowerJSStoreProperty(Node* node) {
359 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node); 359 CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
360 const StorePropertyParameters& p = StorePropertyParametersOf(node->op()); 360 const StorePropertyParameters& p = StorePropertyParametersOf(node->op());
361 LanguageMode language_mode = OpParameter<LanguageMode>(node); 361 LanguageMode language_mode = OpParameter<LanguageMode>(node);
362 // We have a special case where we do keyed stores but don't have a type
363 // feedback vector slot allocated to support it. In this case, install
364 // the megamorphic keyed store stub which needs neither vector nor slot.
365 bool use_vector_slot = FLAG_vector_stores && p.feedback().index() != -1;
362 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode( 366 Callable callable = CodeFactory::KeyedStoreICInOptimizedCode(
363 isolate(), language_mode, UNINITIALIZED); 367 isolate(), language_mode,
364 if (FLAG_vector_stores) { 368 (use_vector_slot || !FLAG_vector_stores) ? UNINITIALIZED : MEGAMORPHIC);
365 DCHECK(p.feedback().index() != -1); 369 if (use_vector_slot) {
366 node->InsertInput(zone(), 3, jsgraph()->SmiConstant(p.feedback().index())); 370 node->InsertInput(zone(), 3, jsgraph()->SmiConstant(p.feedback().index()));
367 } else { 371 } else {
368 node->RemoveInput(3); 372 node->RemoveInput(3);
369 } 373 }
370 ReplaceWithStubCall(node, callable, 374 ReplaceWithStubCall(node, callable,
371 CallDescriptor::kPatchableCallSite | flags); 375 CallDescriptor::kPatchableCallSite | flags);
372 } 376 }
373 377
374 378
375 void JSGenericLowering::LowerJSStoreNamed(Node* node) { 379 void JSGenericLowering::LowerJSStoreNamed(Node* node) {
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 } 845 }
842 846
843 847
844 MachineOperatorBuilder* JSGenericLowering::machine() const { 848 MachineOperatorBuilder* JSGenericLowering::machine() const {
845 return jsgraph()->machine(); 849 return jsgraph()->machine();
846 } 850 }
847 851
848 } // namespace compiler 852 } // namespace compiler
849 } // namespace internal 853 } // namespace internal
850 } // namespace v8 854 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698