Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1252293002: Revert of Allow WebGL on Android if the GPU has it's own process (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
CC:
aelias_OOO_until_Jul13, chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow WebGL on Android if the GPU has it's own process (patchset #6 id:100001 of https://codereview.chromium.org/1247093006/) Reason for revert: Change suspected to have caused the Android builders to start failing the following tests: WebglConformance.conformance_attribs_gl_enable_vertex_attrib WebglConformance.conformance_attribs_gl_vertex_attrib WebglConformance.conformance_attribs_gl_vertexattribpointer WebglConformance.conformance_attribs_gl_vertexattribpointer_offsets WebglConformance.conformance_attribs_gl_vertex_attrib_zero_issues WebglConformance.conformance_buffers_buffer_bind_test WebglConformance.conformance_buffers_buffer_data_array_buffer WebglConformance.conformance_buffers_index_validation_copies_indices WebglConformance.conformance_buffers_index_validation_crash_with_buffer_sub_data WebglConformance.conformance_buffers_index_validation_verifies_too_many_indices WebglConformance.conformance_buffers_index_validation_with_resized_buffer See build logs: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/1179 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%206%29/builds/1475 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/1306 Original issue's description: > Allow WebGL on Android if the GPU has it's own process > > BUG=512992 > > Committed: https://crrev.com/29443deeb43de94ed4c8cd38329f1527e4641d03 > Cr-Commit-Position: refs/heads/master@{#340198} TBR=aelias@chromium.org,kbr@chromium.org,mkwst@chromium.org,zmo@chromium.org,bajones@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512992 Committed: https://crrev.com/5633c8de60635e8d4ed17aee1dd3186a0375a4df Cr-Commit-Position: refs/heads/master@{#340244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -63 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/gpu_control_list.h View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M gpu/config/gpu_control_list_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M gpu/config/gpu_info.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_info.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_info_collector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/software_rendering_list_json.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alancutter (OOO until 2018)
Created Revert of Allow WebGL on Android if the GPU has it's own process
5 years, 5 months ago (2015-07-24 09:40:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252293002/1
5 years, 5 months ago (2015-07-24 09:41:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 09:42:16 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 09:42:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5633c8de60635e8d4ed17aee1dd3186a0375a4df
Cr-Commit-Position: refs/heads/master@{#340244}

Powered by Google App Engine
This is Rietveld 408576698